chore(deps-dev): bump @size-limit/time from 13.1.1 to 14.0.0 - #609
dependabot[bot] wants to merge 2 commits into
Conversation
Bumps [@size-limit/time](https://github.com/ai/size-limit) from 13.1.1 to 14.0.0. - [Release notes](https://github.com/ai/size-limit/releases) - [Changelog](https://github.com/ai/size-limit/blob/main/CHANGELOG.md) - [Commits](ai/size-limit@13.1.1...14.0.0) --- updated-dependencies: - dependency-name: "@size-limit/time" dependency-version: 14.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
dependabot
Bot
added
dependencies
|
@copilot review the changes in this PR as well as 608, 607 and 606 and update to pass also update the dependabot settings so that these packages are all updated together as a single dependabot PR |
Co-authored-by: nev21 <82737406+nev21@users.noreply.github.com>
Addressed in d22d40a. The PR now includes the related |
| "name": "es5-full", | ||
| "path": "lib/dist/es5/mod/ts-utils.js", | ||
| "limit": "37.75 kb", | ||
| "limit": "55.5 kb", |
There was a problem hiding this comment.
Because size-limit 14 changes how these checks are measured. @size-limit/preset-small-lib moved to rolldown by default in v14, so the reported bundle sizes increased even though the library code did not. I raised only the limits that started failing so npm run size would pass with the new toolchain.
There was a problem hiding this comment.
@copilot Why does rolldown cause the bundle size to be larger
There was a problem hiding this comment.
Because @size-limit/preset-small-lib switched from esbuild in 13.1.1 to rolldown in 14.0.0. Different bundlers make different tree-shaking, interop, and minification choices, so the measured bundled output can change even when this repo’s source code does not. In this PR the increase looks like toolchain drift from that bundler swap, not a library code-size regression.
There was a problem hiding this comment.
@copilot my question is not a generic why, I want an analysis of what is not being tree-shaken
There was a problem hiding this comment.
I dug into the actual saved size-limit bundles from 13.1.1 vs 14.0.0 for this repo. For the selective cases ({ getWindow } and the es5-env import set), I do not see an unrelated module/API staying live — both versions pull the same dependency closure around the lazy global lookup/cache helpers (safe, _getGlobalValue, _getGlobalConfig, cached-value wrapper, lazy accessor). The big difference is that the 14.0.0 rolldown output is much less aggressively collapsed/minified: es5-env goes from 1303B to 1690B, getWindow from 927B to 1126B, and the full bundle from 37657B to 55351B. So my current read is: this is not one obvious thing failing to tree-shake; it’s mostly a bundler/output-optimization difference in the new preset.
nevware21-bot
left a comment
nevware21-bot
left a comment
There was a problem hiding this comment.
Approved by nevware21-bot
Bumps @size-limit/time from 13.1.1 to 14.0.0.
Release notes
Sourced from @size-limit/time's releases.
Changelog
Sourced from @size-limit/time's changelog.
Commits
b1d4c43Release 14.0 versionbe6aec9Update dependencies2b763e3Fix test and docs951aef2Move from esbuild to rolldown in small lib preset464d07dReduce dependencies8afbde1Remove nanoid5f549b8Unify Node.js supportDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)