fix(stream): stop discarding rich message parameters - #2910
Open
solracsf wants to merge 1 commit into
Open
Conversation
PHP encodes an empty parameter map as `[]` and a filled one as an object, so
both getters have to normalise the empty-array case. `subjectRichObjects`
did; `messageRichObjects` had the test negated, so it returned an empty map
whenever parameters were present and an array when they were not.
The consumers are CommentActivity and GenericActivity, so any activity whose
message carried rich parameters - a comment with a mention, for instance -
rendered its raw {placeholder} tokens instead of substituting them.
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP encodes an empty parameter map as
[]and a filled one as an object, so both getters have to normalise the empty-array case.subjectRichObjectsdoes.messageRichObjectshad the test negated, so it returned an empty map whenever parameters were present, and an array when they were not.The consumers are
CommentActivityandGenericActivity, so any activity whose message carries rich parameters — a comment with a mention, for instance — rendered its raw{placeholder}tokens instead of substituting them.One character in the fix; the test is the point.