Skip to content

feat: Sensitivity labels - #16991

Merged
alperozturk96 merged 35 commits into
masterfrom
feat/sensivity-label
Jul 16, 2026
Merged

feat: Sensitivity labels#16991
alperozturk96 merged 35 commits into
masterfrom
feat/sensivity-label

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented May 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

No description provided.

@alperozturk96 alperozturk96 changed the title featsensivity label feat: sensivity label May 5, 2026
@alperozturk96
alperozturk96 force-pushed the feat/sensivity-label branch from 1ef545c to 43b91a7 Compare May 5, 2026 08:58
@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/25367658493/artifacts/6803200937
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
alperozturk96 marked this pull request as draft May 11, 2026 13:45
@tobiasKaminsky
tobiasKaminsky force-pushed the feat/sensivity-label branch 2 times, most recently from ca4eb85 to 9f5fa96 Compare July 15, 2026 08:49
@alperozturk96
alperozturk96 force-pushed the feat/sensivity-label branch from 9f5fa96 to 1169974 Compare July 15, 2026 08:50
alperozturk96
alperozturk96 commented Jul 15, 2026
View reviewed changes
Comment thread app/src/main/java/com/nextcloud/client/database/migrations/Migration100to101.kt Outdated
Comment thread app/src/main/java/com/nextcloud/ui/fileInfo/FileInfoViewModel.kt Outdated
Comment thread settings.gradle.kts Outdated
@tobiasKaminsky tobiasKaminsky changed the title feat: sensivity label feat: Sensitivity labels Jul 16, 2026
@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/29474717593/artifacts/8366333756
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@tobiasKaminsky

tobiasKaminsky commented Jul 16, 2026

Copy link
Copy Markdown
Member

SpotBugs increased!

This is within Dagger generated code.

@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/29479162345/artifacts/8367971764
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/29479963693/artifacts/8368295019
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
alperozturk96 force-pushed the feat/sensivity-label branch from 2dec617 to 781fd9c Compare July 16, 2026 11:24
@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3232
Correctness6666
Dodgy code213214
Experimental11
Malicious code vulnerability22
Multithreaded correctness2929
Performance4141
Security1919
Total403404

SpotBugs increased!

@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/29494644580/artifacts/8374183403
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96 alperozturk96 added this to the Nextcloud App 34.1.0 milestone Jul 16, 2026
@alperozturk96
alperozturk96 marked this pull request as ready for review July 16, 2026 13:10
alperozturk96 and others added 12 commits July 16, 2026 15:10
@alperozturk96
wip
bebb1c9 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
Rename .java to .kt
53ad566 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
introduce file info fragment, separate image detail logic
505305f 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
simplify, split gov logic
56b1904 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
simplify, split gov logic
0cd4e96 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
split ui, better margins
f15e473 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
use m3 card to distinc between sections
7f73b00 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
simplify
bee18e1 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
a9c23fa 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
89e25aa 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
a760315 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@tobiasKaminsky @alperozturk96
show details depending on governance app
e6daf81 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
tobiasKaminsky and others added 22 commits July 16, 2026 15:10
@tobiasKaminsky @alperozturk96
wip
050219a 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky @alperozturk96
wip
a544aee 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky @alperozturk96
wip
ec30422 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky @alperozturk96
wip
4b65bb6 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky @alperozturk96
wip
928f837 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky @alperozturk96
wip
12f38b3 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky @alperozturk96
wip
9c1a7de 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky @alperozturk96
wip
c4a1b24 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky @alperozturk96
wip
2df9158 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@alperozturk96
use repository pattern
37db1b8 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
remove nullable flow data use sealed interface
b598d87 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
revert setting.gradle.kts
518da6f 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
make file retention positive button filled tonal button
a2dc9cd 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
remove manual migration
b604384 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
remove manual migration
c264e95 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
refactor(file-info): initialize FileInfoViewModel via AssistedInject
d887c43 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@tobiasKaminsky @alperozturk96
Sensitivity labels are now an array, but in first iteration only one …
20ff953 
…item is set, thus always use first entry

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky @alperozturk96
update lib
47dd8a8 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky @alperozturk96
remove unused files
e92ca08 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky @alperozturk96
use one api call for fetching available labels
3162c6f 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@alperozturk96
update library
383f111 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
update library
4e89f46 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
alperozturk96 force-pushed the feat/sensivity-label branch from 49844bd to 4e89f46 Compare July 16, 2026 13:10
@alperozturk96
update spotbugs for AssistedFactory
3646a40 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
alperozturk96 merged commit df1ddfa into master Jul 16, 2026
15 of 18 checks passed
@alperozturk96
alperozturk96 deleted the feat/sensivity-label branch July 16, 2026 13:15
@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16991-IT-master-15-52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

Nextcloud App 34.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@alperozturk96 @tobiasKaminsky