Skip to content

Whiteboard on Mobile - #16998

Closed
tobiasKaminsky wants to merge 1 commit into
masterfrom
whiteboard
Closed

tobiasKaminsky wants to merge 1 commit into
masterfrom
whiteboard

Conversation

@tobiasKaminsky

Copy link
Copy Markdown
Member

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🏁 Checklist

  • Tests written, or not not needed

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness6767
Dodgy code216218
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3434
Performance4242
Security1616
Total420422

SpotBugs increased!

@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/25419134186/artifacts/6823725075
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

}

public void openFileAsWhiteboard(OCFile file, Context context) {
Intent collaboraWebViewIntent = new Intent(context, WhiteboardWebView.class);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naming? 😁

override fun onResume() {
super.onResume()
webView.evaluateJavascript(
"if (typeof OCA.RichDocuments.documentsMain.postGrabFocus !== 'undefined') " +

@blizzz blizzz May 6, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

P.S.: OK, got it, essentially an mostly unadjusted copy of the richdocs view at this state 🙂

@tobiasKaminsky

Copy link
Copy Markdown
Member Author

Actually it seems we do not need it, but can only rely on generic direct editing implementation 🎉

@github-project-automation github-project-automation Bot moved this from 🏗️ In progress to ☑️ Done in 🤖 🍏 Mobile clients team May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

Whiteboard in app

2 participants