Skip to content

Use new auto folder creation feture available since Nextcloud 32 - #17618

Merged
alperozturk96 merged 9 commits into
masterfrom
feature/create-folder-during-upload
Oct 14, 2026
Merged

alperozturk96 merged 9 commits into
masterfrom
feature/create-folder-during-upload

Conversation

@daniele-verducci

@daniele-verducci daniele-verducci commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

Use new auto folder creation feture available since Nextcloud 32 instead of explicitly creating folders before an upload.
The library PR is: nextcloud/android-library#2141

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

@github-actions

github-actions Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

📱 QA build

Download app-qa-debug.apk
QR code Open the QR code for this download
Commit 4160bc1
Version 17618
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@daniele-verducci

Copy link
Copy Markdown
Contributor Author

This is ready to review

@github-actions

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

Comment thread app/src/main/java/com/owncloud/android/operations/UploadFileOperation.java Outdated
Comment thread app/src/main/java/com/owncloud/android/operations/UploadFileOperation.java Outdated
@daniele-verducci
daniele-verducci force-pushed the feature/create-folder-during-upload branch 2 times, most recently from 8ecd813 to 671bc32 Compare September 15, 2026 09:39
@daniele-verducci

Copy link
Copy Markdown
Contributor Author

Hey @alperozturk96 , thanks for the review! I fixed it!

@daniele-verducci

Copy link
Copy Markdown
Contributor Author

Tests are failing, I'm checking them

@daniele-verducci
daniele-verducci force-pushed the feature/create-folder-during-upload branch from d2cda94 to d03927c Compare September 16, 2026 09:46
@github-actions

Copy link
Copy Markdown

@daniele-verducci
daniele-verducci force-pushed the feature/create-folder-during-upload branch from d03927c to 3d0053b Compare September 16, 2026 16:31
@daniele-verducci

Copy link
Copy Markdown
Contributor Author

Tests should be fixed now, let's see next CI run

@codecov

codecov Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 62.74510% with 19 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ncloud/android/operations/UploadFileOperation.java 30.43% 9 Missing and 7 partials ⚠️
...ils/extensions/FileDataStorageManagerExtensions.kt 88.88% 2 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@github-actions

Copy link
Copy Markdown

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@daniele-verducci

Copy link
Copy Markdown
Contributor Author

Ok, test are all green, I'll rebase and then can be merged

@daniele-verducci
daniele-verducci force-pushed the feature/create-folder-during-upload branch from 3d0053b to 506cfb8 Compare September 28, 2026 07:17
@alperozturk96
alperozturk96 force-pushed the feature/create-folder-during-upload branch from 27ff96b to 764620c Compare October 1, 2026 12:26
@alperozturk96
alperozturk96 force-pushed the feature/create-folder-during-upload branch from 721d59b to 829387e Compare October 1, 2026 13:08
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

master-IT test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3130
Correctness5555
Dodgy code181177
Experimental11
Malicious code vulnerability22
Multithreaded correctness2626
Performance3534
Security1616
Total347341

daniele-verducci and others added 9 commits October 14, 2026 09:46
…ture

Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Co-authored-by: Alper Öztürk <67455295+alperozturk96@users.noreply.github.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
…rsion)

Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@daniele-verducci
daniele-verducci force-pushed the feature/create-folder-during-upload branch from 829387e to 4160bc1 Compare October 14, 2026 07:46
@alperozturk96
alperozturk96 merged commit 0cb643e into master Oct 14, 2026
23 of 26 checks passed
@alperozturk96
alperozturk96 deleted the feature/create-folder-during-upload branch October 14, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants