Skip to content

perf(bitmap): recycle - #17786

Merged
alperozturk96 merged 2 commits into
masterfrom
perf/bitmap-usage
Oct 12, 2026
Merged

perf(bitmap): recycle#17786
alperozturk96 merged 2 commits into
masterfrom
perf/bitmap-usage

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

Implements: #17640

Changes

  • After using bitmaps recycles them
  • Implements ComponentCallbacks2 for FileThumbnailGenerator.kt so that we can do cleanup job.
  • Uses ThumbnailUtils.OPTIONS_RECYCLE_INPUT so that we can recycle the input in extractThumbnail(Bitmap,int,int,int)
  • Moves Bitmap related logics to BitmapUtils.kt instead having them in ThumbnailCacheManager.java

How to test?

  • Check avatar generation in the file list and file detail
  • Check media and album tabs
  • Check previews in file listing
  • Check previews in unified search

@alperozturk96 alperozturk96 added 3. to review performance 🚀 Performance improvement opportunities (non-crash related) labels Oct 8, 2026
@alperozturk96 alperozturk96 changed the title perf(bitmap): usage perf(bitmap): recycle Oct 8, 2026
@github-actions

github-actions Bot commented Oct 8, 2026 •
edited
Loading

Copy link
Copy Markdown

📱 QA build
Download app-qa-debug.apk
QR code Open the QR code for this download
Commit 44fa662
Version 17786
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@codecov

codecov Bot commented Oct 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 36.36364% with 56 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ncloud/android/ui/preview/pdf/PreviewPdfAdapter.kt 0.00% 14 Missing ⚠️
...utils/thumbnail/job/MediaThumbnailGenerationJob.kt 0.00% 9 Missing ⚠️
...loud/android/datamodel/ThumbnailsCacheManager.java 25.00% 8 Missing and 1 partial ⚠️
...ain/java/com/owncloud/android/utils/BitmapUtils.kt 60.00% 6 Missing and 2 partials ⚠️
...wncloud/android/ui/preview/PreviewImageFragment.kt 0.00% 6 Missing ⚠️
...extcloud/utils/thumbnail/FileThumbnailGenerator.kt 50.00% 3 Missing and 1 partial ⚠️
...m/owncloud/android/ui/adapter/DiskLruImageCache.kt 62.50% 2 Missing and 1 partial ⚠️
.../main/java/com/nextcloud/utils/BitmapExtensions.kt 71.42% 1 Missing and 1 partial ⚠️
...d/client/jobs/gallery/GalleryImageGenerationJob.kt 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@alperozturk96
perf(bitmap): usage
cccf7fd 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

# Conflicts:
#	app/src/main/java/com/owncloud/android/datamodel/ThumbnailsCacheManager.java
@alperozturk96
fix build
44fa662 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions

github-actions Bot commented Oct 12, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3030
Correctness5352
Dodgy code177175
Experimental11
Malicious code vulnerability22
Multithreaded correctness2626
Performance3431
Security1616
Total339333

@alperozturk96 alperozturk96 linked an issue Oct 12, 2026 that may be closed by this pull request
Memory Optimization #17640
Closed
@alperozturk96
alperozturk96 merged commit 72d1790 into master Oct 12, 2026
23 of 24 checks passed
@alperozturk96
alperozturk96 deleted the perf/bitmap-usage branch October 12, 2026 11:24
@alperozturk96 alperozturk96 added this to the Nextcloud App 35.1.0 milestone Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daniele-verducci daniele-verducci daniele-verducci approved these changes
@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees

No one assigned

Labels

3. to review performance 🚀 Performance improvement opportunities (non-crash related)

Projects

None yet

Milestone

Nextcloud App 35.1.0

Development

Successfully merging this pull request may close these issues.

Memory Optimization

2 participants

@alperozturk96 @daniele-verducci