Repository navigation
Fix local/remote image file comparison - #17826
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
📱 QA build
The QA build installs alongside a released Nextcloud app, so you can keep Downloading the file requires a GitHub account, so open this link on the |
19a0263 to
2a97b57
Compare
8882810 to
a547766
Compare
| } | ||
|
|
||
| @Test | ||
| fun testAreImageDimensionsSameWhenLocalFileIsNotImage_ShouldReturnTrue() { |
There was a problem hiding this comment.
Let's follow the conventions used in the rest of the project.
For example, we could use testAreImageDimensionsSameWhenLocalFileIsNotImageShouldReturnTrue or like
, as seen in `ManualAsyncRunnerTest` or `OCFileDepthTests`.
In the long run, we should decide which naming convention to follow consistently.
There was a problem hiding this comment.
I tried, but it fails with "Identifier not allowed in Android projects".
Asked Claude to explain and it says it's an instrumented test and is then compiled in DEX, where spaces aren't supported until SDK 30. I can't move it to the normal tests because it uses Bitmap from android.graphics
…al one (it doesn't fail when dimensions are unknown) Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com> # Conflicts: # app/src/main/java/com/nextcloud/utils/extensions/RemoteFileExtensions.kt
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
a547766 to
332f6f5
Compare
2 participants
🏁 Checklist
/backport to stable-xx.x🤖 AI (if applicable)