Skip to content

refactor(thumbail-cache-manager): resized image generation - #17851

Open
alperozturk96 wants to merge 4 commits into
masterfrom
refactor/resized-image-generation-task
Open

refactor(thumbail-cache-manager): resized image generation#17851
alperozturk96 wants to merge 4 commits into
masterfrom
refactor/resized-image-generation-task

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Oct 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Changes

  • ResizedImageGenerationTask converts async Java task to Kotlin lifecycle aware coroutine.
  • Simplifies logic and adds better logs.
  • Removes dead codes.
  • De-duplicated screen size logic.
  • Replaces deprecated api with display metrics.

@alperozturk96 alperozturk96 added ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) 3. to review labels Oct 20, 2026
@alperozturk96
alperozturk96 force-pushed the refactor/resized-image-generation-task branch from 9456d11 to ca4e7f2 Compare October 20, 2026 10:36
@codecov

codecov Bot commented Oct 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 1.70940% with 115 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...nextcloud/utils/thumbnail/ResizedImageGenerator.kt 0.00% 54 Missing ⚠️
...d/utils/thumbnail/job/ResizedImageGenerationJob.kt 0.00% 47 Missing ⚠️
...d/android/ui/preview/media/PreviewMediaFragment.kt 0.00% 8 Missing ⚠️
...ain/java/com/nextcloud/utils/view/ScreenMetrics.kt 40.00% 3 Missing ⚠️
...d/client/jobs/gallery/GalleryImageGenerationJob.kt 0.00% 2 Missing ⚠️
...loud/android/datamodel/ThumbnailsCacheManager.java 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions

github-actions Bot commented Oct 20, 2026 •
edited
Loading

Copy link
Copy Markdown

📱 QA build
Download app-qa-debug.apk
QR code Open the QR code for this download
Commit 75c655a
Version 17851
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@github-actions

github-actions Bot commented Oct 20, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice2524
Correctness5251
Dodgy code161161
Experimental11
Malicious code vulnerability11
Multithreaded correctness2020
Performance2828
Security1615
Total304301

@alperozturk96
remove dead code
2c2c8cd 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
refactor(thumbail-cache-manager): resized image generation
9a331f7 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
deduplicate display size logic
e00baec 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
replace deprecated api with display metrics
75c655a 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
alperozturk96 force-pushed the refactor/resized-image-generation-task branch from ca4e7f2 to 75c655a Compare October 21, 2026 14:58

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daniele-verducci daniele-verducci daniele-verducci approved these changes
@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees

No one assigned

Labels

3. to review ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alperozturk96 @daniele-verducci