Skip to content

feat(navigator): synced folder activity - #17854

Merged
alperozturk96 merged 4 commits into
masterfrom
feat/navigator-synced-folders-activity
Oct 21, 2026
Merged

alperozturk96 merged 4 commits into
masterfrom
feat/navigator-synced-folders-activity

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator
Screenshot 2026-10-20 at 15 02 46

Changes

  • Uses fragment and NavigatorActivity instead having another activity.
  • Simplifies logic and splits into smaller classes.
  • Reorganize package structure.

How to test?

  1. Open auto upload from settings
  2. Open auto upload from notification after new folder detected
  3. Configure, remove, modify auto upload configuration
  4. Check storage (all files, media only, none) permission and upload warning banner (power saving mode, app background usage) handling.

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

@alperozturk96 alperozturk96 added the navigation Navigation matters (e.g. covered under #11072) label Oct 20, 2026
@alperozturk96 alperozturk96 added this to the Nextcloud App 35.1.0 milestone Oct 20, 2026
@alperozturk96 alperozturk96 added AI assisted ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Oct 20, 2026
@github-actions

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice2424
Correctness5151
Dodgy code161161
Experimental11
Malicious code vulnerability11
Multithreaded correctness2020
Performance2828
Security1616
Total302302

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

📱 QA build

Download app-qa-debug.apk
QR code Open the QR code for this download
Commit ab74cf7
Version 17854
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@daniele-verducci

daniele-verducci commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Test results: (WIP)

  • Delete folder -> the folder is deleted, but the list is not updated (until you go back to Settings and re-open Auto Upload)

@alperozturk96

Copy link
Copy Markdown
Collaborator Author

Test results: (WIP)

  • Delete folder -> the folder is deleted, but the list is not updated (until you go back to Settings and re-open Auto Upload)

Did you check on master? and I didn't fully get where did you delete the folder.

@daniele-verducci

daniele-verducci commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Test results: (WIP)

  • Delete folder -> the folder is deleted, but the list is not updated (until you go back to Settings and re-open Auto Upload)

Did you check on master? and I didn't fully get where did you delete the folder.

Hey Alper,
I just checked, confirm it's happening only in this branch.
You can reproduce like in the video (first app is prod from F-Droid, second one is QA):

Screen_recording_20261021_141216.mp4

I also tested on master, same as prod app

This is the only bug I found

@daniele-verducci daniele-verducci left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing completed. The only bug I found is:

  • Delete folder -> the folder is deleted, but the list is not updated (until you go back to Settings and re-open Auto Upload)

Working on master and last prod build

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
alperozturk96 force-pushed the feat/navigator-synced-folders-activity branch from bfffd97 to ab74cf7 Compare October 21, 2026 12:37
@daniele-verducci
daniele-verducci self-requested a review October 21, 2026 13:11

@daniele-verducci daniele-verducci left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After further testing, it seems the issue is already present on master and not introduced by this PR.
For that, I created a separate issue: #17862

@alperozturk96
alperozturk96 merged commit e0630f0 into master Oct 21, 2026
21 of 23 checks passed
@alperozturk96
alperozturk96 deleted the feat/navigator-synced-folders-activity branch October 21, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review AI assisted navigation Navigation matters (e.g. covered under #11072) ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants