Skip to content

fix: do not log the database password on startup #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyteinsky merged 2 commits into from
Sep 1, 2026
Merged

fix: do not log the database password on startup #343

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b25fcb
fix: do not log the database password on startup
bakiburakogun Aug 30, 2026
72a965a
fix: redact passwords that contain an at sign
bakiburakogun Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion dockerfile_scripts/pgsql/setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@ if [ -n "${EXTERNAL_DB}" ]; then
exit 1
fi

echo "Using EXTERNAL_DB, CCB_DB_URL is set to: $EXTERNAL_DB"
# the password must not reach the container log
redacted_db_url=$(printf '%s' "$EXTERNAL_DB" | sed -E 's#(://[^:/@]*):[^/]*@#\1:***@#')
echo "Using EXTERNAL_DB, CCB_DB_URL is set to: $redacted_db_url"

if ! grep -q "^export EXTERNAL_DB=" /etc/environment; then
echo "export EXTERNAL_DB=\"$EXTERNAL_DB\"" >> /etc/environment
Expand Down