Skip to content

chore: update sharing status icon #8498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
madbob wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: update sharing status icon #8498

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/stores/board.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,15 +142,20 @@ export const useBoardStore = defineStore('board', {
},
async loadBoardById(boardId) {
this.filter = { tags: [], users: [], due: '', unassigned: false, completed: 'both' }
this.setCurrentBoard(null)
const board = await apiClient.loadById(boardId)
this.setCurrentBoard(board)
this.setAssignableUsers(board.users)
try {
const board = await apiClient.loadById(boardId)
this.setCurrentBoard(board)
this.addBoard(board)
this.setAssignableUsers(board.users)
} catch (err) {
this.setCurrentBoard(null)

@blizzz blizzz Oct 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any error reporting is swallowed, there is no user feedback in such a case. Maybe better throw again after the setCurrentBoard call.

}
},
async refreshBoard(boardId) {
const board = await apiClient.loadById(boardId)
const etagHasChanged = board.ETag !== this.currentBoard?.ETag
this.setCurrentBoard(board)
this.addBoard(board)
this.setAssignableUsers(board.users)

if (etagHasChanged) {
Expand Down