Skip to content

fix(activity): keep the subject identifier when parsing events #8631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tcarrondo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(activity): keep the subject identifier when parsing events #8631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/Activity/DeckProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,6 @@ protected function setSubjects(IEvent $event, $subject, array $parameters) {

$event->setParsedSubject(str_replace($placeholders, $replacements, $subject))
->setRichSubject($subject, $richParameters);
$event->setSubject($subject, $parameters);
}

private function getIcon(IEvent $event) {
Expand Down
3 changes: 3 additions & 0 deletions tests/unit/Activity/DeckProviderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,8 @@ public function testParseObjectTypeCard() {
$this->assertEquals('test string Card', $event->getParsedSubject());
$this->assertEquals('test string {card}', $event->getRichSubject());
$this->assertEquals('', $event->getMessage());
// the subject stays the identifier: notifications reject subjects longer than 64 characters
$this->assertEquals(ActivityManager::SUBJECT_CARD_CREATE, $event->getSubject());
}

public function testParseObjectTypeCardWithDiff() {
Expand Down Expand Up @@ -312,6 +314,7 @@ public function testParseObjectTypeCardWithDiff() {
$this->assertEquals('test string {card}', $event->getRichSubject());
$this->assertEquals('BCD', $event->getMessage());
$this->assertEquals('BCD', $event->getParsedMessage());
$this->assertEquals(ActivityManager::SUBJECT_CARD_UPDATE_DESCRIPTION, $event->getSubject());
}

public function testParseParamForBoard() {
Expand Down