Skip to content

Fix compatibility with Nextcloud 33 - #259

Open
stephancordes wants to merge 41 commits into
nextcloud:mainfrom
stephancordes:main
Open

Fix compatibility with Nextcloud 33#259
stephancordes wants to merge 41 commits into
nextcloud:mainfrom
stephancordes:main

Conversation

@stephancordes

@stephancordes stephancordes commented Apr 9, 2026

Copy link
Copy Markdown

Changes

  • Updated appinfo/info.xml max-version to 33
  • Updated @nextcloud/* dependencies in package.json
  • Migrated file actions to registerFileAction() API (NC 28+)
  • Migrated new file menu to addNewFileMenuEntry() API (NC 28+)

Tested on

  • Nextcloud 33
  • Rocky Linux / Plesk
  • PHP 8.5

Fixes #191

Cloude Code did most of the work

@AndyScherzinger

AndyScherzinger commented Apr 10, 2026

Copy link
Copy Markdown
Member

#243

Should address the 33 compatibility issues already and @miaulalala also did a v34 compatibility PR already.

Is his PR still needed @stephancordes? Also seems to be Claude gone nuts in terms of commits 😕

@AndyScherzinger AndyScherzinger mentioned this pull request Apr 11, 2026
Closed
@AndyScherzinger AndyScherzinger added bug Something isn't working enhancement New feature or request labels Apr 11, 2026
Copilot AI reviewed Apr 11, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Files MindMap Nextcloud app for compatibility up to Nextcloud 33 by aligning frontend build/configuration, adding MIME/extension handling, and refreshing localization strings used by the newer file actions / new-file menu integrations.

Changes:

  • Adjust Vite build configuration and add generated public bundle output.
  • Add/extend file-type handling metadata (KM extension + Nextcloud mimetype mapping).
  • Update server-side save behavior and refresh many i18n strings (including new “Saved as …”/conversion prompts).

Reviewed changes

Copilot reviewed 213 out of 219 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
vite.config.ts Tweaks Vite build behavior (preserve output dir, raise chunk warning limit) and removes Vue dedupe config.
src/plugins/km.js Adds extensions: ['km'] metadata for KM plugin.
src/tests/plugins/freemind.spec.js Removes legacy global setup from FreeMind plugin tests.
package.json Bumps app package version and updates Nextcloud-related JS dependencies.
lib/Controller/PublicFileHandlingController.php Adjusts public-share save conflict check to only run when mtime is non-empty.
lib/Controller/FileHandlingController.php Normalizes load path joining and adjusts save conflict check to only run when mtime is non-empty; removes path leakage in generic error response.
l10n/zh_TW.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/zh_TW.js Updates strings (new “Saved as …”/conversion prompts).
l10n/zh_HK.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/zh_HK.js Updates strings (new “Saved as …”/conversion prompts).
l10n/zh_CN.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/zh_CN.js Updates strings (new “Saved as …”/conversion prompts).
l10n/vi.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/vi.js Updates strings (new “Saved as …”/conversion prompts).
l10n/uz.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/uz.js Updates strings (new “Saved as …”/conversion prompts).
l10n/ur_PK.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/ur_PK.js Updates strings (new “Saved as …”/conversion prompts).
l10n/uk.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/uk.js Updates strings (new “Saved as …”/conversion prompts).
l10n/ug.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/ug.js Updates strings (new “Saved as …”/conversion prompts).
l10n/tr.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/tr.js Updates strings (new “Saved as …”/conversion prompts).
l10n/tk.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/tk.js Updates strings (new “Saved as …”/conversion prompts).
l10n/th.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/th.js Updates strings (new “Saved as …”/conversion prompts).
l10n/ta.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/ta.js Updates strings (new “Saved as …”/conversion prompts).
l10n/sw.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/sw.js Updates strings (new “Saved as …”/conversion prompts).
l10n/sv.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/sv.js Updates strings (new “Saved as …”/conversion prompts).
l10n/sr@latin.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/sr@latin.js Updates strings (new “Saved as …”/conversion prompts).
l10n/sr.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/sr.js Updates strings (new “Saved as …”/conversion prompts).
l10n/sq.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/sq.js Updates strings (new “Saved as …”/conversion prompts).
l10n/sl.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/sl.js Updates strings (new “Saved as …”/conversion prompts).
l10n/sk.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/sk.js Updates strings (new “Saved as …”/conversion prompts).
l10n/sc.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/sc.js Updates strings (new “Saved as …”/conversion prompts).
l10n/ru.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/ru.js Updates strings (new “Saved as …”/conversion prompts).
l10n/ro.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/ro.js Updates strings (new “Saved as …”/conversion prompts).
l10n/pt_PT.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/pt_PT.js Updates strings (new “Saved as …”/conversion prompts).
l10n/pt_BR.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/pt_BR.js Updates strings (new “Saved as …”/conversion prompts).
l10n/ps.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/ps.js Updates strings (new “Saved as …”/conversion prompts).
l10n/pl.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/pl.js Updates strings (new “Saved as …”/conversion prompts).
l10n/oc.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/oc.js Updates strings (new “Saved as …”/conversion prompts).
l10n/nn_NO.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/nn_NO.js Updates strings (new “Saved as …”/conversion prompts).
l10n/nl.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/nl.js Updates strings (new “Saved as …”/conversion prompts).
l10n/nb.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/nb.js Updates strings (new “Saved as …”/conversion prompts).
l10n/ms_MY.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/ms_MY.js Updates strings (new “Saved as …”/conversion prompts).
l10n/mn.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/mn.js Updates strings (new “Saved as …”/conversion prompts).
l10n/mk.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/mk.js Updates strings (new “Saved as …”/conversion prompts).
l10n/lv.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/lv.js Updates strings (new “Saved as …”/conversion prompts).
l10n/lt_LT.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/lt_LT.js Updates strings (new “Saved as …”/conversion prompts).
l10n/lo.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/lo.js Updates strings (new “Saved as …”/conversion prompts).
l10n/lb.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/lb.js Updates strings (new “Saved as …”/conversion prompts).
l10n/ko.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/ko.js Updates strings (new “Saved as …”/conversion prompts).
l10n/kn.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/kn.js Updates strings (new “Saved as …”/conversion prompts).
l10n/km.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/km.js Updates strings (new “Saved as …”/conversion prompts).
l10n/kab.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/kab.js Updates strings (new “Saved as …”/conversion prompts).
l10n/ka.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/ka.js Updates strings (new “Saved as …”/conversion prompts).
l10n/ka_GE.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/ka_GE.js Updates strings (new “Saved as …”/conversion prompts).
l10n/ja.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/ja.js Updates strings (new “Saved as …”/conversion prompts).
l10n/it.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/it.js Updates strings (new “Saved as …”/conversion prompts).
l10n/is.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/is.js Updates strings (new “Saved as …”/conversion prompts).
l10n/id.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/id.js Updates strings (new “Saved as …”/conversion prompts).
l10n/ia.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/ia.js Updates strings (new “Saved as …”/conversion prompts).
l10n/hy.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/hy.js Updates strings (new “Saved as …”/conversion prompts).
l10n/hu.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/hu.js Updates strings (new “Saved as …”/conversion prompts).
l10n/hr.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/hr.js Updates strings (new “Saved as …”/conversion prompts).
l10n/he.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/he.js Updates strings (new “Saved as …”/conversion prompts).
l10n/gl.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/gl.js Updates strings (new “Saved as …”/conversion prompts).
l10n/gd.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/gd.js Updates strings (new “Saved as …”/conversion prompts).
l10n/ga.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/ga.js Updates strings (new “Saved as …”/conversion prompts).
l10n/fr.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/fr.js Updates strings (new “Saved as …”/conversion prompts).
l10n/fi.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/fi.js Updates strings (new “Saved as …”/conversion prompts).
l10n/fa.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/fa.js Updates strings (new “Saved as …”/conversion prompts).
l10n/eu.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/eu.js Updates strings (new “Saved as …”/conversion prompts).
l10n/et_EE.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/et_EE.js Updates strings (new “Saved as …”/conversion prompts).
l10n/es.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/es.js Updates strings (new “Saved as …”/conversion prompts).
l10n/es_UY.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/es_UY.js Updates strings (new “Saved as …”/conversion prompts).
l10n/es_SV.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/es_SV.js Updates strings (new “Saved as …”/conversion prompts).
l10n/es_PY.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/es_PY.js Updates strings (new “Saved as …”/conversion prompts).
l10n/es_PR.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/es_PR.js Updates strings (new “Saved as …”/conversion prompts).
l10n/es_PE.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/es_PE.js Updates strings (new “Saved as …”/conversion prompts).
l10n/es_PA.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/es_PA.js Updates strings (new “Saved as …”/conversion prompts).
l10n/es_NI.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/es_NI.js Updates strings (new “Saved as …”/conversion prompts).
l10n/es_MX.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/es_MX.js Updates strings (new “Saved as …”/conversion prompts).
l10n/es_HN.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/es_HN.js Updates strings (new “Saved as …”/conversion prompts).
l10n/es_GT.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/es_GT.js Updates strings (new “Saved as …”/conversion prompts).
l10n/es_EC.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/es_EC.js Updates strings (new “Saved as …”/conversion prompts).
l10n/es_DO.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/es_DO.js Updates strings (new “Saved as …”/conversion prompts).
l10n/es_CR.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/es_CR.js Updates strings (new “Saved as …”/conversion prompts).
l10n/es_CO.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/es_CO.js Updates strings (new “Saved as …”/conversion prompts).
l10n/es_CL.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/es_CL.js Updates strings (new “Saved as …”/conversion prompts).
l10n/es_AR.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/es_AR.js Updates strings (new “Saved as …”/conversion prompts).
l10n/es_419.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/es_419.js Updates strings (new “Saved as …”/conversion prompts).
l10n/eo.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/eo.js Updates strings (new “Saved as …”/conversion prompts).
l10n/en_GB.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/en_GB.js Updates strings (new “Saved as …”/conversion prompts).
l10n/el.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/el.js Updates strings (new “Saved as …”/conversion prompts).
l10n/de.js Updates strings (new “Saved as …”/conversion prompts).
l10n/de_DE.js Updates strings (new “Saved as …”/conversion prompts).
l10n/da.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/da.js Updates strings (new “Saved as …”/conversion prompts).
l10n/cy_GB.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/cy_GB.js Updates strings (new “Saved as …”/conversion prompts).
l10n/cs.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/cs.js Updates strings (new “Saved as …”/conversion prompts).
l10n/ca.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/ca.js Updates strings (new “Saved as …”/conversion prompts).
l10n/bs.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/bs.js Updates strings (new “Saved as …”/conversion prompts).
l10n/br.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/br.js Updates strings (new “Saved as …”/conversion prompts).
l10n/bn_BD.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/bn_BD.js Updates strings (new “Saved as …”/conversion prompts).
l10n/bg.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/bg.js Updates strings (new “Saved as …”/conversion prompts).
l10n/be.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/be.js Updates strings (new “Saved as …”/conversion prompts).
l10n/az.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/az.js Updates strings (new “Saved as …”/conversion prompts).
l10n/ast.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/ast.js Updates strings (new “Saved as …”/conversion prompts).
l10n/ar.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/ar.js Updates strings (new “Saved as …”/conversion prompts).
l10n/af.json Updates strings (new “Saved as …”/conversion prompts) and normalizes JSON formatting.
l10n/af.js Updates strings (new “Saved as …”/conversion prompts).
js/files_mindmap-public.mjs Adds/updates built JS bundle for public-view handling.
appinfo/mimetypemapping.json Adds extension→mimetype mapping for .km files.
appinfo/info.xml Bumps app version metadata.
.gitignore Stops ignoring js/ and adds .claude/.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/Controller/FileHandlingController.php
Comment thread lib/Controller/PublicFileHandlingController.php
stephancordes pushed a commit to stephancordes/files_mindmap that referenced this pull request Apr 11, 2026
root @claude
fix: require mtime on save to enforce conflict detection
92b05b8 
Previously, an empty/missing mtime bypassed the optimistic-lock check
entirely (Copilot review on nextcloud#259), allowing clients to silently overwrite
concurrent changes. Now both FileHandlingController and
PublicFileHandlingController reject save requests without mtime with
HTTP 400 before the conflict check runs.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@AndyScherzinger

AndyScherzinger commented Apr 11, 2026

Copy link
Copy Markdown
Member

In the end @stephancordes you'll have to do a rebase to get rid of the merge conflict, see https://github.com/nextcloud/files_mindmap/pull/259/conflicts for the dependencies. Can be done at any time of course

@AndyScherzinger

AndyScherzinger commented Apr 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Also please add the sign-off, see https://github.com/nextcloud/files_mindmap/pull/259/checks?check_run_id=70903816397 or add it as a comment in the PR description.

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~39 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin main

Thanks in advance ❤️

stephancordes and others added 19 commits April 11, 2026 11:44
stephancordes @claude
test: rewrite MindMap spec to cover FilesMindMap class and extend vit…
692f8f9 
…e build config

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: stephancordes <stephan@cordes.site>
stephancordes @claude
test: expand FilesMindMap test suite; chore: fix npm audit vulnerabil…
0c00bc7 
…ities

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: stephancordes <stephan@cordes.site>
stephancordes @claude
test: rewrite MindMap spec to cover FilesMindMap class
4aff868 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: stephancordes <stephan@cordes.site>
stephancordes @claude
chore: bump version to 0.0.35
165065f 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: stephancordes <stephan@cordes.site>
stephancordes @claude
fix: use new addNewFileMenuEntry API for NC 33+ and set DEFAULT actio…
c83e5e0 
…n type

- Import addNewFileMenuEntry from @nextcloud/files (v4) alongside legacy
- registerNewFileMenuPlugin() now uses the v4 API for version >= 33 so the
  "New mind map" entry appears in the Files new-file menu on NC 33+
- Change DefaultType.HIDDEN to DefaultType.DEFAULT so clicking a .km file
  triggers the file action and opens the viewer
- Rebuild JS bundles

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: stephancordes <stephan@cordes.site>
stephancordes @claude
fix: support NC 28+ Node.path in setFile and guard against missing hi…
2d20096 
…de()

- setFile() now reads file.path ?? file.filename so NC 28+ Viewer's Node
  objects are handled correctly (path was always undefined → wrong dir)
- Replace OCA.FilesMindMap.hide() calls in viewer.js with optional chaining
  so load failures no longer crash when hide() is not defined

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: stephancordes <stephan@cordes.site>
stephancordes @claude
fix: resolve FilesMindMap global ref in freemind plugin and mime fall…
4dd6edd 
…back for new files

- freemind.js: replace bare FilesMindMap.Util.xml2json() (ReferenceError in
  ES module scope) with imported util.xml2json()
- mindmap.js load(): when server returns unsupported mime (e.g. octet-stream
  for a freshly created empty .km file), fall back to extension-based mime
  detection against registered plugins

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: stephancordes <stephan@cordes.site>
stephancordes @claude
test: cover setFile(Node.path), load() mime fallback, and drop obsole…
af71a8d 
…te global mock

- mindmap.spec.js: add two setFile tests for NC 28+ Node objects (path
  instead of filename) and one load() test for octet-stream mime fallback
- freemind.spec.js: remove the global.FilesMindMap = { Util: util } workaround
  now that freemind.js imports util directly

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: stephancordes <stephan@cordes.site>
stephancordes @claude
test: add MindMap compatibility tests for Nextcloud 33
32145a5 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: stephancordes <stephan@cordes.site>
stephancordes @claude
test: add MindMap compatibility tests for Nextcloud 33
c80c162 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: stephancordes <stephan@cordes.site>
stephancordes @claude
chore: untrack built JS bundles (already covered by .gitignore)
22075be 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: stephancordes <stephan@cordes.site>
stephancordes @claude
fix: update compatibility for Nextcloud 33
2b8b4aa 
- save(): guard against null plugin when mime is unknown (TypeError crash)
- load(): extend extension fallback to use plugin.extensions array
- freemind.js: add extensions: ['mm'] for octet-stream fallback matching
- Application.php: register .mm -> application/x-freemind mime type
- registerNewFileMenuPlugin: separate translatable name from .km extension
  so translated filenames always get the correct extension appended
- l10n: rename 'New mind map.km' key to 'New mind map' in 50 translation
  files and strip accidental .km suffixes from translated values

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: stephancordes <stephan@cordes.site>
stephancordes @claude
fix: remove debug line that overwrote save error message with file path
2cbd903 
$message = $path accidentally replaced the l10n error string with the
raw file path, hiding the real error from the user on unexpected
exceptions during save.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: stephancordes <stephan@cordes.site>
stephancordes @claude
chore: track built JS bundles and remove from .gitignore
3a3f0ed 
Nextcloud apps are deployed by copying files directly — no build step
on the server. Keeping the bundles in git ensures the deployed code
always matches the source and prevents stale-bundle issues like the
ones fixed in this branch.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: stephancordes <stephan@cordes.site>
stephancordes @claude
fix: resolve saving, new file extension, and MIME detection bugs for …
07a909e 
…NC 33

- Fix mtime conflict check to skip when mtime is empty (prevented saving)
- Fix new file source URL encoding to preserve .km extension
- Set _file.mime immediately in setFile() from Viewer Node object
- Add extensions: ['km'] to km plugin for explicit extension fallback
- Remove dedupe: ['vue'] from vite config to fix Vue 2/3 build conflict
- Add appinfo/mimetypemapping.json for belt-and-suspenders MIME hint
- Rebuild JS bundles

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: stephancordes <stephan@cordes.site>
stephancordes @claude
fix: robust WebDAV URL for new files, Ctrl+S in parent frame
856ef7a 
- Construct WebDAV URL via generateRemoteUrl instead of context.encodedSource
  to reliably preserve .km extension regardless of NC files context object
- Add console.debug to log PUT URL for debugging
- Add Ctrl+S keydown handler in MindMap.vue (parent frame) so browser
  does not intercept the shortcut when focus is outside the iframe

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: stephancordes <stephan@cordes.site>
stephancordes @claude
fix: editor layout, Ctrl+S capture, .mm→.km save, PHP path double-slash
f1e926d 
- viewer.php: minder-editor-container top: 0 → 40px so menu bar is visible
- viewer.js: Ctrl+S uses capture-phase listener to intercept before KityMinder
- mindmap.js: .mm files are saved as new .km via WebDAV PUT instead of failing
- FileHandlingController: rtrim() prevents double-slash in load path (fixes
  "file not found" immediately after new file creation)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: stephancordes <stephan@cordes.site>
stephancordes @claude
chore: bump version to 0.0.36, add CHANGELOG
787b84c 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: stephancordes <stephan@cordes.site>
stephancordes @claude
docs: expand CHANGELOG with all 0.0.36 changes including NC 33 compat
f3cb873 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: stephancordes <stephan@cordes.site>
stephancordes and others added 3 commits April 11, 2026 11:44
stephancordes @claude
fix(0.0.46): fix Export dropdown clipped by overflow:hidden
cb80f28 
#header-controls had overflow:hidden which clipped the dropdown opening
downward. Changed to overflow:visible and added z-index:2000 on
.dropdown-menu to ensure it appears above the KityMinder canvas.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: stephancordes <stephan@cordes.site>
stephancordes @claude
fix(0.0.47): implement FilesMindMap.hide() so close button works
9a747dc 
OCA.FilesMindMap.hide() was never defined — the optional call hide?.()
from the iframe silently returned undefined. The new method clicks
.modal-container__close programmatically; the button is display:none
!important but still in the DOM, and element.click() bypasses CSS
visibility to fire the Vue handler.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: stephancordes <stephan@cordes.site>
stephancordes @claude
fix: require mtime on save to enforce conflict detection
bb602a4 
Previously, an empty/missing mtime bypassed the optimistic-lock check
entirely (Copilot review on nextcloud#259), allowing clients to silently overwrite
concurrent changes. Now both FileHandlingController and
PublicFileHandlingController reject save requests without mtime with
HTTP 400 before the conflict check runs.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: stephancordes <stephan@cordes.site>
stephancordes added 2 commits April 11, 2026 11:47
stephancordes
chore: merge upstream/main and regenerate package-lock.json
7cdb843 
Signed-off-by: stephancordes <stephan@cordes.site>
stephancordes
chore: remove upstream workflow file not needed in fork
6376213 
Signed-off-by: stephancordes <stephan@cordes.site>
@stephancordes

stephancordes commented Apr 11, 2026

Copy link
Copy Markdown
Author

The PR should now show no conflicts:

  • appinfo/info.xml — merged cleanly (our 0.0.47 + upstream's updated author)
  • package-lock.json — regenerated cleanly
  • appstore-build-publish.yml — removed (not needed in fork)

@AndyScherzinger

AndyScherzinger commented Apr 11, 2026

Copy link
Copy Markdown
Member

appstore-build-publish.yml — removed (not needed in fork)

@stephancordes Yeah well, when opening a PR you are deleting it upstream... so no, you can't delete it claude ;)

package-lock.json — regenerated cleanly

It has a huge amount of changes which I would not expect but I am not an expert on it, so @miaulalala might know better

appinfo/info.xml — merged cleanly (our 0.0.47 + upstream's updated author)

Should actually stick to 0.0.34 simply due to the fact that 0.0.33 has been the last release, so there is no need to constantly bump the version number in the meta data due to changes since the bump would happen at release time

@stephancordes

stephancordes commented Apr 11, 2026

Copy link
Copy Markdown
Author

@AndyScherzinger
what kind of changes are needed on my sied? (This is my first Git repository. It was originally intended to be private only. But it would have been a shame not to share the work.)

@AndyScherzinger

AndyScherzinger commented Apr 12, 2026

Copy link
Copy Markdown
Member

@stephancordes See
https://github.com/nextcloud/files_mindmap/actions/runs/24281838946/job/70914143016?pr=259#step:6:41
https://github.com/nextcloud/files_mindmap/actions/runs/24281838953/job/70914151975?pr=259#step:6:40

npm error npm cican only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file withnpm install before continuing.

So currently not all checks can be executed. So this would need to get fixed first. After that we can have a look and get it merged later. for a first, new release we would leave this out, to keep changes at a minimum, in case we need to search for issues with that minimal release it is easier if the change set is smaller.

Could you cover the above and add it to your branch? Thanks in adavance

@miaulalala

miaulalala commented Apr 14, 2026

Copy link
Copy Markdown
Collaborator

Additionally, all l10n files can go - they are maintained via transifex.

@stephancordes

stephancordes commented Apr 14, 2026

Copy link
Copy Markdown
Author

Yes, i will do both tomorrow.

@henmohr

henmohr commented May 18, 2026

Copy link
Copy Markdown

Go @stephancordes ?

@AndyScherzinger

AndyScherzinger commented May 18, 2026

Copy link
Copy Markdown
Member

@henmohr see feedback in #269 (title is misleading) regarding people testing 0.1.0-beta release which provide compatibility to 33 and have been successfully tested while they all needed an uninstall / reinstall of the app since something is still off with the update from 0.33.0 to newer versions since the app transfer.

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

miaulalala
miaulalala requested changes Jul 21, 2026
View reviewed changes

@miaulalala miaulalala left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling NC33 compatibility! The core registerFileAction()/addNewFileMenuEntry() migration looks structurally sound, but the diff is a lot bigger than the description suggests (mostly generated build/l10n noise, but also some bundled-in unrelated changes), and a few things need a closer look before merging.

  • Verify the appstore CI workflow deletion is intentional. .github/workflows/appstore-build-publish.yml appears to be deleted with nothing added to replace it. If that's not intentional (e.g. replaced by an org-wide reusable workflow elsewhere), this would mean future tagged releases stop being built/signed/published to the appstore — this alone should block merge until confirmed.

  • Please split this PR. The actual NC33 compatibility migration (file-action API, version bump, dependency updates) is a small, reviewable change on its own. The .mm→.km auto-conversion feature, the Viewer-chrome-hiding DOM hacks in MindMap.vue, and the Firefox SVGTextElement monkey-patch are unrelated features/fixes that deserve their own PRs — they're also the least-tested, highest-risk parts of this diff.

  • Duplicate test files. src/__tests__/MindMap.spec.js and src/__tests__/mindmap.spec.js are now byte-identical. Besides being redundant, this can collide on case-insensitive filesystems (macOS/Windows CI). Please keep one and either restore genuine MindMap.vue component coverage or note that it's intentionally dropped.

  • vite.config.ts: emptyOutDir: false. Was this intentional? Not clearing the output dir before build risks shipping stale JS chunks alongside new ones — a plausible contributor to the broken 0.0.34-beta.1 release. Clearing the output dir is normally the safer default.

  • Two unannounced behavior changes worth double-checking:

    • DefaultType.HIDDEN → DefaultType.DEFAULT in registerFileActions() changes the double-click default action for mind-map files across all supported NC versions, not just 33.
    • The new empty($mtime) guard in both FileHandlingController::save() and PublicFileHandlingController::save() — since empty(0) is true in PHP, could this incorrectly reject a save where mtime is legitimately 0?

Nice catch, unrelated but worth calling out: removing the $message = $path; line in FileHandlingController::save() looks like a genuine bug fix (it was overwriting the translated error message with a raw file path, a minor info leak) — good to keep, just worth mentioning explicitly in the PR description since it's easy to lose track of in a large diff.

@Object9050

Object9050 commented Sep 8, 2026

Copy link
Copy Markdown

A fix of the compatibility of the mind map app with Nextcloud 33 would be appreciated.

@AndyScherzinger

AndyScherzinger commented Sep 8, 2026

Copy link
Copy Markdown
Member

@Object9050 the latest releases cover v33. If you still face issues please report them specifically than I can have a look when time permits 👍

@AndyScherzinger

AndyScherzinger commented Sep 8, 2026

Copy link
Copy Markdown
Member

However, I keep this PT open, to harvest any improvements not yet put in place elsewhere already

@Object9050

Object9050 commented Sep 8, 2026

Copy link
Copy Markdown

@Object9050 the latest releases cover v33. If you still face issues please report them specifically than I can have a look when time permits 👍

Thank you! I had to delete the cookies. Now it's working just fine.

@AndyScherzinger

AndyScherzinger commented Sep 8, 2026

Copy link
Copy Markdown
Member

Thank you! I had to delete the cookies. Now it's working just fine.

Happy to hear that 🎉

This was referenced Oct 27, 2026
Merged
Merged
Merged
Merged
Open
@AndyScherzinger

AndyScherzinger commented Oct 27, 2026

Copy link
Copy Markdown
Member

Thank you @stephancordes for this PR and the analysis behind it. Rather than merging it as a whole (it also carried build output, l10n changes and Nextcloud 33 work that has meanwhile shipped), its remaining fixes were taken over as focused PRs:

The idea of saving .mm (and .xmind) maps as .km is being continued in #102, with a proposal there for how it should work.

This was referenced Oct 28, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@miaulalala miaulalala miaulalala requested changes

Assignees

No one assigned

Labels

bug Something isn't working enhancement New feature or request feedback-requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NC 28 compatibility

6 participants

@stephancordes @AndyScherzinger @miaulalala @henmohr @Object9050