Repository navigation
fix(deps): lift vue to 3.5.44 and drop unused Vue dependencies - #387
Merged
Merged
Conversation
Both were only needed for the Vue viewer component, which #375 replaced with a custom element. Nothing imports vue or @vue/test-utils anymore. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
vue and @vue/server-renderer require each other at the exact same version, so npm audit fix could not move the hoisted copy off 3.5.33, which GHSA-g2v6-rqmx-r4w6 affects (fixed in 3.5.42). npm dedupe hoists 3.5.44 instead; the rest are patch and minor updates within the existing ranges. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The npm audit workflow (run) reported 2 fixable vulnerabilities but opened no PR, because
npm audit fixchanged nothing.The 2 fixable items are
vueand@vue/server-renderer3.5.33, affected by GHSA-g2v6-rqmx-r4w6 (high, fixed in 3.5.42). They stay at 3.5.33 because:floating-vueandemoji-mart-vue-fast(via@nextcloud/vuefrom@nextcloud/dialogsand@nextcloud/viewer) only declarevueas a peer, so npm satisfies them with one hoisted copy.vueand@vue/server-rendererrequire each other at the exact same version, so neithernpm audit fixnornpm update vuecan move that pair.peerDependenciesentry"vue": ">=2.7.0"pinned it as well.Changes:
vuepeer dependency and the@vue/test-utilsdev dependency. Both were only needed for the Vue viewer component, which fix(viewer): migrate to @nextcloud/viewer for Nextcloud 36 #375 replaced with a custom element; nothing imports either anymore.npm dedupe, which hoistsvue/@vue/*3.5.44. Everything else it touches is a patch or minor update within the existing ranges (e.g.@babel/parser,bn.js,minimatch,undici, vite's nested esbuild 0.27.2 → 0.28.2).npm auditgoes from 17 vulnerabilities (5 high) to 15 (3 high). The rest are only fixable with--force: a breaking change ofvite-plugin-static-copy, and the@nextcloud/vite-configpolyfill/vite-plugin-dtschain, which has no fix yet.Since
@nextcloud/viewerbundles the Vue runtime into this app's JS, the change ships, so it was tested in the browser on 32, 34 and 36 (open, save, public share).🤖 AI (if applicable)