Repository navigation
fix(ui): unlock text block dialog when saving fails - #13942
Merged
Merged
Conversation
The loading state was only cleared on success, so a failed save left the Ok button spinning and Cancel disabled with no way to close the dialog. The sharee search in the same dialog still keeps its spinner after a failed request; that is left for a separate fix. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Grigory Vodyanov <scratchx@gmx.com>
GVodyanov
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
October 25, 2026 22:53
hamza221
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #13797 (comment)
The loading state was only cleared on success, so a failed save left the Ok button spinning and Cancel disabled with no way to close the dialog.
The sharee search in the same dialog still keeps its spinner after a failed request; that is left for a separate fix.
🤖 AI (if applicable)