Repository navigation
feat(ui): add setting to always show external images - #13947
Open
felixschndr wants to merge 1 commit into
Open
felixschndr wants to merge 1 commit into
felixschndr wants to merge 1 commit into
Conversation
Readers who don't care about remote-content tracking had to trust every sender or domain one by one before images showed. A per-user preference now loads remote content for all messages, the same way it is loaded for a trusted sender. The trusted senders list is hidden while the preference is on, since it has no effect then. Existing trusted senders are kept, so turning the preference off restores the previous behavior. The default stays off to keep the privacy-preserving behavior for everyone else. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Felix Schneider <mail@fschneider.me>
felixschndr
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
October 26, 2026 14:31
|
Thanks for opening your first pull request in this repository! ✌️ |
Contributor
|
I'm not sure, if we want to add this setting. |
Author
|
Why not? It's an opt-in setting for users and many mail platforms do this as their default. I don't see a point of not giving the user the option |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a "Always show images" switch to Mail settings → Privacy. When enabled, remote images and styles are loaded for every message without the blocked-content warning, instead of requiring each sender or domain to be trusted manually.
always-show-external-images(defaultfalse), provided via initial stateMessageHTMLBodytreats every sender as trusted while the preference is on; no trusted-sender entries are createdTesting
PageControllerTestfor the new initial-state key🤖 AI (if applicable)