Skip to content

fix: do not link ambiguous file extensions #13951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
madbob wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −0
Open

fix: do not link ambiguous file extensions #13951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/Service/Html.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ public function convertLinks(string $data): string {
$linker = new UrlLinker([
'allowFtpAddresses' => true,
'allowUpperCaseUrlSchemes' => false,
'skipAmbiguousTlds' => true,
'htmlLinkCreator' => static fn ($url)
// Render full url for the link description. Otherwise, potentially malicious query
// params might be hidden.
Expand Down
13 changes: 13 additions & 0 deletions tests/Unit/Service/HtmlTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,19 @@ public function testLinkDetectionLeavesValidMultibyteTextUnchanged(): void {
self::assertStringContainsString("\u{1F609}", $withLinks);
}

public function testDoNotLinkAmbiguousExtensions(): void {
$urlGenerator = Server::get(IURLGenerator::class);
$request = Server::get(IRequest::class);
$hmacGenerator = $this->createStub(ProxyHmacGenerator::class);

$html = new Html($urlGenerator, $request, $hmacGenerator);
$text = '/home/user/something/text.java';
$result = $html->convertLinks($text);

self::assertStringContainsString('/home/user/something/text.java', $result);
$this->assertStringNotContainsString('http', $result);
}

/**
* @dataProvider parseMailBodyProvider
* @param $expected
Expand Down
Loading