Skip to content

improve sync error handling - #3396

Open
alperozturk96 wants to merge 7 commits into
mainfrom
feat/improve-error-feedback
Open

improve sync error handling#3396
alperozturk96 wants to merge 7 commits into
mainfrom
feat/improve-error-feedback

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Oct 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Changes

  • Exposes meaningful errors to the user instead just saying sync error.
  • Simplifies NotesServerSyncTask.java

@codacy-production

codacy-production Bot commented Oct 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Not up to standards ⛔

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 35 complexity · 0 duplication

Metric Results
Complexity 35
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

alperozturk96
alperozturk96 commented Oct 14, 2026
View reviewed changes
Comment thread app/src/main/res/values/strings.xml

<string name="error_sync">Synchronization failed: %1$s</string>
<string name="error_synchronization">Synchronization failed</string>
<string name="error_sync_locked">A note is open in another app. Close it there to sync your changes.</string>

@alperozturk96 alperozturk96 Oct 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jancborchardt Can you check the messages? Maybe we can provide better wording.

@alperozturk96 alperozturk96 added this to the 35.1.0 milestone Oct 14, 2026
@github-actions

github-actions Bot commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/notes-android/actions/runs/38530041575/artifacts/11877942277
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
alperozturk96 requested a balanced review from Copilot October 14, 2026 07:58
@alperozturk96 alperozturk96 changed the title improve error handling improve sync error handling Oct 14, 2026
@alperozturk96 alperozturk96 added the sync file syncing label Oct 14, 2026
Copilot AI reviewed Oct 14, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Failure mapping can produce misleading messages and misses synchronous transport errors.

3 open findings
What changed in this PR

Improves sync-error messaging and extracts remote-note merging from the synchronization task.

Changes:

  • Maps sync failures to user-facing messages.
  • Refactors push handling and remote-note merging.
  • Adds structured sync exceptions.

All four new source files are Kotlin. Among changed files, MainActivity.java and strings.xml remain over 300 lines.

File Description
strings.xml Adds sync-error messages.
SyncFailureReason.kt Maps HTTP statuses to failure reasons.
RemoteNotesMerger.kt Extracts remote-note reconciliation.
NoteSyncException.kt Represents failed note operations.
NotesServerSyncTask.java Refactors push, pull, and failure handling.
SyncErrorMessage.kt Selects messages from exceptions.
MainActivity.java Displays specific sync errors.

🧠 Review effort: Balanced

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread app/src/main/java/it/niedermann/owncloud/notes/main/MainActivity.java
Comment thread app/src/main/java/it/niedermann/owncloud/notes/persistence/SyncFailureReason.kt Outdated
Comment thread app/src/main/java/it/niedermann/owncloud/notes/main/SyncErrorMessage.kt
@github-actions

github-actions Bot commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/notes-android/actions/runs/38557863521/artifacts/11892095883
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
expose 423 locked error
81e1bc1 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
expose other errors
3639ea3 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
refactor server sync task
bf1aa07 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix the recreate remoteId bug
f780145 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
better message for HTTP_FORBIDDEN 403
b30f595 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
add token mismatch
4bbfc94 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
improve sync active state
6b0ae68 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
alperozturk96 force-pushed the feat/improve-error-feedback branch from 6f97f00 to 6b0ae68 Compare October 15, 2026 09:32
@alperozturk96

alperozturk96 commented Oct 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

@daniele-verducci PR is updated, could you please review again?

@github-actions

github-actions Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/notes-android/actions/runs/38713756532/artifacts/11961743497
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@daniele-verducci daniele-verducci daniele-verducci approved these changes
@AndyScherzinger AndyScherzinger Awaiting requested review from AndyScherzinger
@jancborchardt jancborchardt Awaiting requested review from jancborchardt

Assignees

No one assigned

Labels

3. to review sync file syncing

Projects

None yet

Milestone

35.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@alperozturk96 @daniele-verducci