Skip to content

replace emojipicker - #6443

Merged
mahibi merged 1 commit into
masterfrom
feature/2735/replaceEmojiPicker
Aug 6, 2026
Merged

replace emojipicker#6443
mahibi merged 1 commit into
masterfrom
feature/2735/replaceEmojiPicker

Conversation

@mahibi

@mahibi mahibi commented Jul 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

for chat: use your keyboards emojipicker
for reaction and set status: replaced vanniktech emojipicker with emoji2 picker

🖼️ Screenshots/Videos

Message Input

🏚️ Before 🏡 After
grafikgrafik grafik

Message reactions

🏚️ Before (flickering) 🏡 After
reactions_flicker better_reaction

Set user status

🏚️ Before (weird bug) 🏡 After
user_status_weird_bug better_status

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@mahibi mahibi added this to the 24.1.0 milestone Jul 31, 2026
@mahibi mahibi self-assigned this Jul 31, 2026
@mahibi
replace emojipicker
901fd20 
for chat: use your keyboards emojipicker
for reaction and set status: replaced vanniktech emojipicker with emoji2 picker

Assisted-by: Claude Code 2.1.199:claude-sonnet-5

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@github-actions

github-actions Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/30637808031/artifacts/8796566804
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@mahibi
mahibi force-pushed the feature/2735/replaceEmojiPicker branch from b8090c2 to 901fd20 Compare July 31, 2026 15:03
@mahibi
mahibi requested a review from rapterjet2004 July 31, 2026 15:03
@github-actions

github-actions Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/30641224471/artifacts/8797700538
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@mahibi mahibi added the 3. to review Waiting for reviews label Aug 3, 2026
@mahibi

mahibi commented Aug 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

there is a bug with nested scrolling for the emojis. It will be fixed with a followup PR together with other changes.

This was referenced Aug 5, 2026
Closed
Open
AndyScherzinger
AndyScherzinger approved these changes Aug 6, 2026
View reviewed changes

@AndyScherzinger AndyScherzinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, only thing is device rotation needs fixing

@mahibi
mahibi merged commit 5011716 into master Aug 6, 2026
16 of 20 checks passed
@mahibi
mahibi deleted the feature/2735/replaceEmojiPicker branch August 6, 2026 15:47
@mahibi

mahibi commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator Author

Nice, only thing is device rotation needs fixing

👍 fixed in #6456

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes
@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

Assignees

@mahibi mahibi

Labels

3. to review Waiting for reviews AI assisted

Projects

None yet

Milestone

24.1.0

Development

Successfully merging this pull request may close these issues.

Emoji covers the keyboard replace emojipicker Emoji form is covering text message field

2 participants

@mahibi @AndyScherzinger