Skip to content

fix(chat): avoid ClassCastException when building FileParameters #6465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mahibi merged 1 commit into from
Aug 11, 2026
+12 −11
Merged

fix(chat): avoid ClassCastException when building FileParameters #6465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions app/src/main/java/com/nextcloud/talk/chat/ChatActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1001,16 +1001,11 @@ class ChatActivity :
var result: String? = null
message?.let {
if (message.messageParameters.isNotEmpty()) {
runCatching {
message.messageParameters as HashMap<String?, HashMap<String?, String?>>?
val fileParameters = FileParameters(message.messageParameters)
result = fileParameters.id
}.onFailure { e ->
when (e) {
is ClassCastException -> {} // weird
else -> Log.e(TAG, "Error in LazyListState.visibleItemsWithThreshold $e")
}
}
val normalizedParameters = HashMap<String?, HashMap<String?, String?>>(
message.messageParameters.mapValues { (_, params) -> HashMap(params) }
)
val fileParameters = FileParameters(normalizedParameters)
result = fileParameters.id
}
}

Expand Down
8 changes: 7 additions & 1 deletion app/src/main/java/com/nextcloud/talk/ui/chat/MediaMessage.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,13 @@ fun MediaMessage(
onImageClick: (Int) -> Unit
) {
val fileParameters =
remember { FileParameters(message.messageParameters as HashMap<String?, HashMap<String?, String?>>?) }
remember {
FileParameters(
HashMap(
message.messageParameters.mapValues { (_, params) -> HashMap(params) }
)
)
}

val hasExplicitCaption = message.plainMessage != FILE_PLACEHOLDER_MESSAGE
val hasPreview = !typeContent.previewUrl.isNullOrEmpty()
Expand Down
Loading