chore/upgrade vue 3#8619

Open

max-nextcloud wants to merge 125 commits into

mainfrom

chore/upgrade-vue-3

max-nextcloud commented May 20, 2026 •

edited by mejo-

Loading

Collaborator

upgrade dependencies to vue3
replace new Vue with createApp
<var>.sync to v-model:<var>
fix imports
Vue.observable to reactive
from beforeDestroy() to beforeUnmount()
key attribute in v-for component

Todos

Table action buttons broken
Editor and Menubar alignment in Collectives broken
Menubar actions keep getting reloaded endlessly
Check if InfoBar properties from Collectives are still reactive
Check if collaboration cursor from other session members show their username
$on no longer exists in Vue 3. We still use it in DirectEditing
Test DirectEditing
Table doesn't spawn full width. Claude says:

Details

max-nextcloud added this to 📝 Productivity team

max-nextcloud moved this to 🏗️ In progress in 📝 Productivity team

max-nextcloud self-assigned this

max-nextcloud force-pushed the chore/upgrade-vue-3 branch 4 times, most recently from 59e04f7 to 232f2dc Compare

June 9, 2026 08:51

max-nextcloud force-pushed the chore/upgrade-vue-3 branch from 232f2dc to e2419c3 Compare

June 29, 2026 09:38

mejo- added enhancement 2. developing technical debt labels

mejo- added this to the Nextcloud 35 milestone

mejo- self-assigned this

mejo- force-pushed the chore/upgrade-vue-3 branch 5 times, most recently from a32e5da to a985bdf Compare

June 30, 2026 16:56

max-nextcloud added 12 commits

July 1, 2026 12:04


          chore(deps): upgrade dependencies to vue3 and freeze tiptap

a92f513

Newer tiptap versions change the way vue elements are rendered.
Make sure it does not get updated while we bump the vue version.

Signed-off-by: Max <max@nextcloud.com>


          chore(deps): replace new Vue with createApp

d4b8878

Also replace `Vue.extend` with `createApp` when it is needed.
In SourceView it can simply be dropped
as we already render SourceView with our own vue instance.

Signed-off-by: Max <max@nextcloud.com>


          chore(upgrade): <var>.sync to v-model:<var>

470a08f

Signed-off-by: Max <max@nextcloud.com>


          chore(upgrade): fix imports

c16b75e

Signed-off-by: Max <max@nextcloud.com>


          chore(upgrade): Vue.observable to reactive

b665b24

Signed-off-by: Max <max@nextcloud.com>


          chore(upgrade): from beforeDestroy() to beforeUnmount()

e786693

Signed-off-by: Max <max@nextcloud.com>


          chore(upgrade): key attribute in v-for component

936d8d8

Signed-off-by: Max <max@nextcloud.com>


          chore(upgrade): use eslint@10 and @nextcloud/eslint@9

8aa4fc1

Signed-off-by: Max <max@nextcloud.com>


          chore(lint): configure vitest globals

2ef059b

We should import them explicitely. But that is for another day.

Signed-off-by: Max <max@nextcloud.com>


          chore(lint): fix what prettier and eslint can agree upon

3ff06ab

Signed-off-by: Max <max@nextcloud.com>


          chore(lint): let eslint sort the imports

84c13b1

Signed-off-by: Max <max@nextcloud.com>


          chore(lint): remove outdated eslint disable lines

c27d6ac

Signed-off-by: Max <max@nextcloud.com>

mejo- and others added 11 commits

July 1, 2026 12:32


          chore: add missing REUSE headers

5b0f9b1

Signed-off-by: Jonas <jonas@freesources.org>


          fix(createTable): add missing defineExposed import

095e1df

Signed-off-by: Jonas <jonas@freesources.org>


          fix(api): await component import in createTable

46ba7c9

defineAsyncComponent left the editor container ref unresolved at mount,
so TextEditorEmbed aborted.

Signed-off-by: Jonas <jonas@freesources.org>


          fix(WidthToggle): listen on update:modelValue

9a00bf8

Signed-off-by: Jonas <jonas@freesources.org>


          test(cypress): fix selector for link input field

135920b

Changed with nextcloud-vue v9.

Signed-off-by: Jonas <jonas@freesources.org>


          test(cypress): strip trailing newlines in expectMarkdown()

85bc1f4

We did this before in the table spec helper function.

Signed-off-by: Jonas <jonas@freesources.org>


          fix(CodeBlock): Fix defaultMode() computed

9044e9e

`supportPreview` is a computed, not a function.

Signed-off-by: Jonas <jonas@freesources.org>


          chore(test): add code block test to playwright

55acfaf

Signed-off-by: Max <max@nextcloud.com>


          fix(CodeBlockView): return early if mermaid block without code

3a8a304

Signed-off-by: Jonas <jonas@freesources.org>


          test(cypress): fix button selector in file picker dialog

1f4ad58

Signed-off-by: Jonas <jonas@freesources.org>


          fix(CollaborativeEditor): pass conflict reader component as string

01609dc

Follow-up to 33c48bf which converted these components to
`defineAsyncComponent()`.

Signed-off-by: Jonas <jonas@freesources.org>

mejo- force-pushed the chore/upgrade-vue-3 branch from 41d6e05 to 01609dc Compare

July 1, 2026 10:35

mejo- marked this pull request as ready for review

July 1, 2026 10:35

mejo- requested review from mejo- and silverkszlo as code owners

July 1, 2026 10:35

mejo- added 2 commits

July 1, 2026 13:05


          fix(ToolBarLogic): menuEntryRefs was moved to data

f864192

Follow-up to e57ffe6.

Signed-off-by: Jonas <jonas@freesources.org>


          fix(PlainTableContentEditor): don't use this.$parent.$emit()

a2ea4aa

Signed-off-by: Jonas <jonas@freesources.org>

max-nextcloud commented

View reviewed changes

src/components/Editor/MediaHandler.vue Outdated

max-nextcloud commented

View reviewed changes

src/helpers/files.js

mejo- added 5 commits

July 1, 2026 13:59


          fix(editor): mark editor component as raw at creation

6b43681

Follow-up of 68ae3fd

Signed-off-by: Jonas <jonas@freesources.org>


          fix(DirectEditing): don't use const for variable that gets altered

288d554

Signed-off-by: Jonas <jonas@freesources.org>


          fix(ImageView): migrate from v-click-outside (vue2) to onClickOutside

638788c

Signed-off-by: Jonas <jonas@freesources.org>


          chore(npm): remove obsolete dependencies vue-template-compiler and vu…

deb1263

…e-demi

Signed-off-by: Jonas <jonas@freesources.org>


          refactor(filePicker): use our filePicker builder in MediaHandler

a9797a7

Also refactor the filePicker builder code a bit.

Signed-off-by: Jonas <jonas@freesources.org>

mejo- force-pushed the chore/upgrade-vue-3 branch from 6539e0a to 2308728 Compare

July 1, 2026 13:25

mejo- added 3 commits

July 1, 2026 18:00


          chore(ViewerComponent): don't emit obsolete update:loaded event

934fe45

We use the `onLoadedHandler()` nowadays as the emitted event didn't
reach the Viewer anyway due to the new ViewerView.js wrapper.

Signed-off-by: Jonas <jonas@freesources.org>


          fix(ViewerView): set inheritAttrs: false for ViewerView

c72a8d0

Prevents attributes from Viewer component being used as HTML element
attributes.

Also simplify createApp ViewerComponent call.

Signed-off-by: Jonas <jonas@freesources.org>


          fix(DirectEditing): save before closing the editor

1f4b605

Before, we used the Vue 2 `$destroy()` function that called the Vue
component teardown cycle - which called save and then close. Vue
3 removed that method.

The former fix to call `close()` here was partial, as it closed the
editor without saving first. So let's `save()` explicitely here as well.

Signed-off-by: Jonas <jonas@freesources.org>

mejo- force-pushed the chore/upgrade-vue-3 branch from 2308728 to 1f4b605 Compare

July 1, 2026 16:02

mejo- approved these changes

View reviewed changes

mejo- left a comment

Member

Ready for merge from my side 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing enhancement technical debt