Add types for markdown extension#8720
Draft
max-nextcloud wants to merge 63 commits into
Draft
Conversation
Signed-off-by: Max <max@nextcloud.com>
Also replace `Vue.extend` with `createApp` when it is needed. In SourceView it can simply be dropped as we already render SourceView with our own vue instance. Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
We should import them explicitely. But that is for another day. Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Introduce `createCollaborativeEditor` and `createMarkdownContentEditor` to superseed `createEditor` with more specific type signatures. Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
`add-image-node` and `delete-image-node` used to be handled by collectives. But collectives is now listening to the event bus directly. I could not find any other handler for these events. Signed-off-by: Max <max@nextcloud.com>
Convert listInputRule to typescript to be able to add proper types. Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
We only use it in Editor and can aswell use a dynamic component instead. Signed-off-by: Max <max@nextcloud.com>
It contains information about: * last saved * collaborator list * offline state So this is the most fitting name I could come up with. Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
The Placeholder extension accesses browser specific apis on init. Signed-off-by: Max <max@nextcloud.com>
Also introduce `testEditor` test helper. Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
chore/upgrade-vue-3
branch
from
b3671aa to
59e04f7
Compare
max-nextcloud
force-pushed
the
chore/type-markdown-extension
branch
from
63d66a1 to
b069a35
Compare
Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
chore/type-markdown-extension
branch
from
b069a35 to
d5a00c9
Compare
max-nextcloud
force-pushed
the
chore/upgrade-vue-3
branch
from
59e04f7 to
232f2dc
Compare
max-nextcloud
force-pushed
the
chore/upgrade-vue-3
branch
from
232f2dc to
e2419c3
Compare
mejo-
force-pushed
the
chore/upgrade-vue-3
branch
4 times, most recently
from
2c3e994 to
a8f1474
Compare
max-nextcloud
force-pushed
the
chore/upgrade-vue-3
branch
from
c17e61b to
41d6e05
Compare
mejo-
force-pushed
the
chore/upgrade-vue-3
branch
from
41d6e05 to
01609dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out our clipboard serializer hands a slice to prosemirror-markdown which expects a node. https://code.haverbeke.berlin/prosemirror/prosemirror-markdown/issues/131