Repository navigation
Conversation
The viewer is part of the server from 36: the setup installed the app anyway and then failed reading its checkout, so no end-to-end test ran against master. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
The viewer moved into the server as @nextcloud/viewer, which takes handlers as custom elements and no longer dispatches LoadViewer or offers OCA.Viewer.registerHandler. On 36 and up, a small init script now registers a <whiteboard-viewer> element on every page, defined the first time a board opens. It renders the board as before: read-only outside the viewer (the preview of a link to the file) and side by side with another version, and an older version from its own source. Servers up to 35 keep the viewer app's LoadViewer path. The main script skips its legacy registration on 36, where it still runs as the board shares chunks with it. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
From Nextcloud 36 the viewer is part of the server, with its own handler API, so supporting older servers meant carrying both registrations. This drops 31 to 35: the LoadViewer listeners, the Vue component registered with OCA.Viewer, the public share runtime and its styles (the server opens a shared board in the viewer itself), the comparison lookup through OCA.Viewer.compareFileInfo, and the LoadViewer stub. The main script is left with the pages whiteboard renders itself: recording and direct editing. Playwright runs against master only. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
Contributor
|
Let's keep this as a draft until we have a stable branch for 31 to 35. main is the only branch shipping 2.x right now. |
Contributor
|
Closing this one. We release only from main now, so requiring 36 here would drop Nextcloud 31 to 35 for everyone on the next release. #1374 is merged and covers 36 next to the older versions. When main drops 31 to 35, we can start again from 989fb7c on this branch. Thanks for preparing both options, it made the comparison easy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #1374, to compare: the same port to the viewer of Nextcloud 36, but
mainrequires 36 and drops 31 to 35.The first two commits are #1374. The last one is the difference: it removes the
LoadViewerlisteners, the Vue component registered withOCA.Viewer, the public share runtime and its styles, the comparison lookup throughOCA.Viewer.compareFileInfoand theLoadViewerstub. That is 918 lines out and 35 in compared to #1374.main.tskeeps the recording and direct editing pages only.Taking this means cutting
stable2.0for 31 to 35 first, since releases frommainwould then only install on 36.On 36 the server opens a publicly shared board in the viewer itself, so the full-page public share layout goes away: the board shows in the viewer modal instead. I checked opening a board, an older version and a public share on a master instance, without console errors. Playwright now runs against master only.
👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.