Repository navigation
Conversation
On Nextcloud 36, IRootFolder::getUserFolder() returns IUserFolder, so the Folder mocks fail with IncompatibleReturnValueException. Mock IUserFolder when it exists. Skip the embed e2e test on master: the Files smart picker and the file reference widget do not work with the Nextcloud 36 viewer yet. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
1 task done
Contributor
Author
|
Included in #1374. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepares the tests for Nextcloud 36, so #1374 can get a green CI on master.
IRootFolder::getUserFolder()returnsIUserFolder, so theFoldermocks fail withIncompatibleReturnValueException(44 errors). The tests now mockIUserFolderwhen it exists.Locally, the affected test classes pass against the server master OCP, except 2 tests that need a full server.
AI