Repository navigation
Conversation
The previous pin assumed that the next release will fix the issue, which is not guaranteed. Instead of allowing another release to potentially break CI, pin to existing versions that are known to work. The pytest and pytest-forked pins are related, so I've added a more detailed comment explaining the situation and what should be done in a likely scenario.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
The previous pin assumed that the next release will fix the issue, which is not guaranteed. Instead of allowing another release to potentially break CI, pin to existing versions that are known to work.
The pytest and pytest-forked pins are related, so I've added a more detailed comment explaining the situation and what should be done in a likely scenario.
Related issue(s)
Follow-up to #543 and #555
Checklist
Update changelogN/A, dev change