Skip to content

Align compilation flags across build systems - #70

Merged
mingxwa merged 1 commit into
ngcpp:mainfrom
mingxwa:user/mingxwa/build-flags
Aug 21, 2026
Merged

Align compilation flags across build systems#70
mingxwa merged 1 commit into
ngcpp:mainfrom
mingxwa:user/mingxwa/build-flags

Conversation

@mingxwa

@mingxwa mingxwa commented Aug 16, 2026

Copy link
Copy Markdown
Member

Changes

  • Set CMAKE_CXX_EXTENSIONS to OFF. It defaults to ON, so CMake was the only toolchain compiling in GNU extension mode, -std=gnu++20 against -std=c++26 under Meson and -std=c++20 under Bazel. No effect on MSVC, where CMake maps standard and extension to the same -std:c++20.
  • Added AppleClang to the -Wno-c++2b-extensions generator expressions in CMakeLists.txt and cmake/msft_proxy4ModuleTargets.cmake. CXX_COMPILER_ID reports AppleClang rather than Clang, while Meson and Bazel both classify it as clang.
  • Defined NDEBUG consistently by setting b_ndebug in Meson and --compilation_mode=opt in Bazel. Only CMake defined it before, leaving PRO4D_DEBUG and assert compiled in under the other two.

Comment thread .bazelrc
@mingxwa
mingxwa merged commit 47976dc into ngcpp:main Aug 21, 2026
17 checks passed
@mingxwa
mingxwa deleted the user/mingxwa/build-flags branch August 21, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants