Repository navigation
Fix CI: disable MSVC warning C5285 for the vendored doctest - #5577
Merged
Merged
Conversation
The windows-11-arm runner now ships MSVC 19.51, which reports doctest's
forward declaration of std::tuple as C5285 ("cannot declare a
specialization for 'std::tuple'"). With /WX this breaks the msvc-arm64
job on develop and on every open pull request. Disable the warning for
the test targets, like the other MSVC warnings already disabled there.
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
windows-11-armrunner now ships MSVC 19.51 (VS 2026). That compiler reports doctest's forward declaration ofstd::tupleas a new warning:/WXturns this into an error, somsvc-arm64fails ondevelop(run 36104393129) and on every open pull request. #5575 fixed the generator name but not this warning.This PR disables C5285 for the test targets in
tests/CMakeLists.txt, next to the other MSVC warnings disabled there. The vendoreddoctest.his unchanged.Breaking changes
None. The change only affects warning flags for the unit tests; the library and its public API are untouched.
🤖 Generated with Claude Code