Repository navigation
Handle all value_t enumerators in has_no_children() - #5770
Merged
Merged
Conversation
2026-10-07: add the scalar enum labels already handled by the default branch so -Werror=switch-enum builds succeed. Keep the existing behavior and synchronize the generated single header. Signed-off-by: fhgffy <102001626+fhgffy@users.noreply.github.com>
3 of 4 tasks
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI builds with
-Werror=switch-enumfail after #5762 becausehas_no_children()explicitly handles onlyarrayandobject. Adefaultbranch does not suppress this warning.Add the other eight
value_tlabels to the existingreturn truebranch and regenerate the single header. The behavior stays the same. This fixes the warning reported on #5760 and complements the separate ObjectType fix in #5767.Validation with MinGW GCC 15.1:
tests/abi/diag/diag_off.cppfails before the patch with-std=c++11 -Wswitch-enum -Werror=switch-enum, using either header mode. It passes after the patch in C++11 and C++20.git diff --checkpass.The full suite was not rerun; the separate
rbegin()build failure remains until #5767 lands.