Repository navigation
Use the with_*_t aliases in the remaining tests and docs - #5790
Merged
Merged
Conversation
#5787 missed the instantiations spelled as `basic_json <` (astyle's formatting) or ending in the CustomBaseClass argument. Convert them, including the binary_t.md example pointed out in review. Signed-off-by: Niels Lohmann <mail@nlohmann.me>
github-actions
Bot
added
documentation
aspect: binary formats
gregmarr
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #5787, as pointed out in #5787 (comment). #5787 missed the instantiations written as
basic_json <(astyle's formatting) or ending in theCustomBaseClassargument. This converts the remaining 15:docs/mkdocs/docs/api/basic_json/binary_t.md:ordered_json::with_binary_t<std::vector<std::byte>>(the one @gregmarr found)docs/mkdocs/docs/examples/as_base_class.cpp,tests/src/unit-custom-base-class.cpp(2):with_base_class_ttests/src/unit-bson.cpp(2),tests/src/unit-custom-binary-type.cpp(2),tests/src/unit-msgpack.cpp(6),tests/src/unit-ordered_json2.cpp(1):with_binary_t/with_string_t/with_array_t/with_object_tEach alias changes exactly the parameters that differed from the defaults, so every type is unchanged. A second sweep of
tests/src,docs, andREADME.mdfound no other spelled-out instantiations. The ones left are those where the parameter list is the subject (alias tests inunit-udt.cpp,with_t.md,ordered_json.md, explicit instantiations).Verified locally:
test-bson,test-msgpack,test-custom-base-class,test-ordered_json2(C++11) andtest-custom-binary-type(C++11 and C++17, covering thestd::bytebranch) pass. Theas_base_classexample output matches its.outputfile.Public API
No breaking changes. Only tests, an example, and documentation are touched.
🤖 Generated with Claude Code