Repository navigation
Expect type_error.321 for deep discarded values in the BON8 writer test - #5807
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-large_jsonfails on develop since two pull requests merged on 2026-10-10 met in one test:to_bon8throwtype_error.321for discarded values.unit-large_json.cpp, which still expected a deep discarded value to be written as nothing (0x81per array).The test now expects
type_error.321for the deep discarded value, asunit-bon8.cppdoes for shallow ones. The rest of the section (errors thrown from below and above the recursion bound) is unchanged.Every pull request based on current develop gets this failure, for example the json_view stack.
Tests
unit-large_json.cpppasses with ASan/UBSan, with and withoutJSON_DIAGNOSTICS.Public API
No breaking changes; test-only.
Written by Claude Code.
🤖 Generated with Claude Code