Repository navigation
Re-amalgamate single_include after #5795 and #5806 - #5808
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Check amalgamationrun on develop (run 38124855188) fails: #5795 (custom object key types) and #5806 (BON8 writer stack overflow) changedinclude/nlohmann/detail/output/binary_writer.hppandtype_traits.hpp, butsingle_include/nlohmann/json.hppwas last regenerated in #5802.This PR is just the output of
make amalgamateon develop (c59ad95). The diff matches the patch the failing check printed, line for line. No file underinclude/changes.Breaking changes
None. The amalgamated header now matches
include/, so users ofsingle_includeget the #5795 and #5806 changes that are already on develop ininclude/.🤖 Generated with Claude Code