Skip to content

revert Richards growth at start year to restore capability#776

Open
Rick-Methot-NOAA wants to merge 1 commit into
mainfrom
fix_Richards_growth_after_330_25
Open

revert Richards growth at start year to restore capability#776
Rick-Methot-NOAA wants to merge 1 commit into
mainfrom
fix_Richards_growth_after_330_25

Conversation

@Rick-Methot-NOAA

@Rick-Methot-NOAA Rick-Methot-NOAA commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Concisely describe what has been changed/addressed in the pull request.

3.30.25 changed Richards growth at start year such that bad gradients could occur for ages < AFIX. This PR restores full capability.

What tests have been done?

Where are the relevant files?

What tests/review still need to be done?

Is there an input change for users to Stock Synthesis?

Additional information (optional).

@e-perl-NOAA

e-perl-NOAA commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

@Rick-Methot-NOAA, i've run the build action on your branch again and it succeeds. This seems to be an issue with the connection to the admb docker container in that it sometimes connects and sometimes doesn't. Idk if this is an issue with recent github actions runner updates and if it will fix itself in the next week or so which happens often which GHA runners. I think we should wait out this issue and see if it resolves on it's own and if not, I've already investigated some potential fixes.

@iantaylor-NOAA iantaylor-NOAA left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Rick-Methot-NOAA Rick-Methot-NOAA linked an issue Jul 23, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status
Status: No status

Development

Successfully merging this pull request may close these issues.

Richards growth curve (and compiler warnings) [Bug]: Richards growth curve no longer converging in 3.30.25

3 participants