Skip to content

fix: update binary-split repository - #1142

Merged
BethGriggs merged 1 commit into
nodejs:mainfrom
reggi:fix/binary-split-repository
Sep 29, 2026
Merged

BethGriggs merged 1 commit into
nodejs:mainfrom
reggi:fix/binary-split-repository

Conversation

@reggi

@reggi reggi commented Sep 23, 2026

Copy link
Copy Markdown

Updates the binary-split lookup entry to use the current max-mapper repository owner.

The package metadata published for binary-split@1.0.5 still points to maxogden/binary-split. npm/cli uses the CITGM lookup repository override when generating its integration matrix, preventing the stale codeload URL from returning a 404.

Addresses npm/cli#10020.

Validation: jq empty lib/lookup.json and git diff --check. The full test suite was not run.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: ce1a4b02-26ae-4c30-a086-491e98d1e6da
@MikeMcC399

Copy link
Copy Markdown
Contributor

This PR should have a commit message lookup: rather than fix:

@codecov-commenter

codecov-commenter commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.20%. Comparing base (9697128) to head (83cf7a2).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1142   +/-   ##
=======================================
  Coverage   96.20%   96.20%           
=======================================
  Files          29       29           
  Lines        2213     2213           
=======================================
  Hits         2129     2129           
  Misses         84       84           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BethGriggs
BethGriggs merged commit 4d3d256 into nodejs:main Sep 29, 2026
11 checks passed
@MikeMcC399

MikeMcC399 commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

I didn't notice this in time to add to this PR, however one of the maintainers (maxogden) of https://github.com/max-mapper/binary-split is no longer on GitHub.

@mourner is stil reachable, however there haven't been any repo updates since Dec 2023.

The package was last published to https://www.npmjs.com/package/binary-split as 1.0.5 on Oct 23, 2018.

Edit: see #1166

@MikeMcC399

MikeMcC399 commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

It also fails in Windows on all Node.js versions. Currently it is marked as flaky for Windows. It would be better to skip it for Windows instead. I'll follow up with a separate PR for this.

Edit: see #1167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants