Skip to content

chore: fix release-please detection of lookup commits - #1146

Merged
BethGriggs merged 1 commit into
nodejs:mainfrom
BethGriggs:lookup-commits
Sep 28, 2026
Merged

BethGriggs merged 1 commit into
nodejs:mainfrom
BethGriggs:lookup-commits

Conversation

@BethGriggs

Copy link
Copy Markdown
Member

Setting lookup: commits to hidden resulted in no changelog changes, meaning we'd still need wait for a user-facing commit to trigger the release PR (or push an empty fix commit).

For now it seems easier to just include lookup: PRs in the changelog. Or, we could consider hiding those updates under <details> sections in the CHANGELOG as a post-step release-please workflow?

Checklist
  • documentation is changed or added
  • contribution guidelines followed
    here

Signed-off-by: Beth Griggs <bethanyngriggs@gmail.com>
@codecov-commenter

codecov-commenter commented Sep 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.20%. Comparing base (45ba271) to head (00ba057).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1146   +/-   ##
=======================================
  Coverage   96.20%   96.20%           
=======================================
  Files          29       29           
  Lines        2213     2213           
=======================================
  Hits         2129     2129           
  Misses         84       84           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@richardlau

Copy link
Copy Markdown
Member

For now it seems easier to just include lookup: PRs in the changelog. Or, we could consider hiding those updates under <details> sections in the CHANGELOG as a post-step release-please workflow?

I think it kind of depends what changed. I would treat new modules being added to lookup as minor and probably worth mentioning in the changelog.

@BethGriggs

BethGriggs commented Sep 28, 2026 •

Copy link
Copy Markdown
Member Author

Hmmm, checking some documentation on release please now as I don't think this will do what we want
Let's try it

@BethGriggs
BethGriggs merged commit 126096c into nodejs:main Sep 28, 2026
11 checks passed
@BethGriggs

Copy link
Copy Markdown
Member Author

#1147 did get opened as expected

I think it kind of depends what changed. I would treat new modules being added to lookup as minor and probably worth mentioning in the changelog.

For those I think we can use feat(lookup): add.... It means we're really just treating lookup: as a conventional alternative to fix(lookup). Probably okay, I was just trying to account for the habit of using lookup: for flakes/skips/etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants