chore: fix release-please detection of lookup commits - #1146
Conversation
Signed-off-by: Beth Griggs <bethanyngriggs@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1146 +/- ##
=======================================
Coverage 96.20% 96.20%
=======================================
Files 29 29
Lines 2213 2213
=======================================
Hits 2129 2129
Misses 84 84 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
I think it kind of depends what changed. I would treat new modules being added to lookup as minor and probably worth mentioning in the changelog. |
|
|
|
#1147 did get opened as expected
For those I think we can use |
Setting
lookup:commits to hidden resulted in no changelog changes, meaning we'd still need wait for a user-facing commit to trigger the release PR (or push an emptyfixcommit).For now it seems easier to just include
lookup:PRs in the changelog. Or, we could consider hiding those updates under<details>sections in the CHANGELOG as a post-step release-please workflow?Checklist
here