Skip to content

lookup: unskip fastify on S390x - #1160

Draft
abhayagarwal-dev wants to merge 1 commit into
nodejs:mainfrom
abhayagarwal-dev:unskip-s390
Draft

abhayagarwal-dev wants to merge 1 commit into
nodejs:mainfrom
abhayagarwal-dev:unskip-s390

Conversation

@abhayagarwal-dev

@abhayagarwal-dev abhayagarwal-dev commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Fastify is failing on AIX, Windows and macOS while passing on s390x. Removing s390x from the skip list and adding win32 and darwin while keeping aix skipped.

CITGM smoke test passed on s390x with Node.js v22.23.2

$ citgm fastify
info: starting            | fastify             
info: lookup              | fastify             
info: lookup-found        | fastify             
info: fastify lookup-replace| https://github.com/fastify/fastify/archive/ba235fdcd9a83a4c7ccf793f7b2596a8f65389b6.tar.gz
info: fastify npm:        | Downloading project: https://github.com/fastify/fastify/archive/ba235fdcd9a83a4c7ccf793f7b2596a8f65389b6.tar.gz
info: fastify npm:        | Project downloaded ba235fdcd9a83a4c7ccf793f7b2596a8f65389b6.tar.gz
info: fastify npm:        | npm install started 
info: fastify npm:        | npm install successfully completed
info: fastify npm:        | test suite started  
info: passing module(s)   |                     
info: module name:        | fastify             
info: version:            | 5.12.5              
info: done                | The smoke test has passed.
info: duration            | test duration: 112615ms
Checklist
  • npm test passes
  • contribution guidelines followed
    here

@codecov-commenter

codecov-commenter commented Oct 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.20%. Comparing base (3b60eb7) to head (2b415e0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1160   +/-   ##
=======================================
  Coverage   96.20%   96.20%           
=======================================
  Files          29       29           
  Lines        2213     2213           
=======================================
  Hits         2129     2129           
  Misses         84       84           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@abhayagarwal-dev

Copy link
Copy Markdown
Contributor Author

I will mark it ready for review once jenkins CI results are available.
Could someone from @nodejs/citgm please trigger a citgm-smoker CI run?

@MikeMcC399

This comment was marked as resolved.

@richardlau

This comment was marked as off-topic.

@MikeMcC399

This comment was marked as off-topic.

@abhayagarwal-dev
abhayagarwal-dev force-pushed the unskip-s390 branch 4 times, most recently from d9ac17f to 345f9c1 Compare October 6, 2026 04:42
@abhayagarwal-dev abhayagarwal-dev changed the title lookup: unskip fastify on s390x and aix lookup: unskip fastify on S390x Oct 6, 2026
@abhayagarwal-dev

Copy link
Copy Markdown
Contributor Author

Based on the Jenkin CI result, https://ci.nodejs.org/job/citgm-smoker-pipeline/296/
Fastify is failing on AIX, WIndows and macos while passing on S390x.
So adding win32 and darwin on skip list and unskipping s390x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants