lookup: unskip fastify on S390x - #1160
Draft
abhayagarwal-dev wants to merge 1 commit into
Draft
abhayagarwal-dev wants to merge 1 commit into
abhayagarwal-dev wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1160 +/- ##
=======================================
Coverage 96.20% 96.20%
=======================================
Files 29 29
Lines 2213 2213
=======================================
Hits 2129 2129
Misses 84 84 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
I will mark it ready for review once jenkins CI results are available. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
abhayagarwal-dev
force-pushed
the
unskip-s390
branch
4 times, most recently
from
October 6, 2026 04:42
d9ac17f to
345f9c1
Compare
abhayagarwal-dev
force-pushed
the
unskip-s390
branch
from
October 6, 2026 04:51
345f9c1 to
2b415e0
Compare
Contributor
Author
|
Based on the Jenkin CI result, https://ci.nodejs.org/job/citgm-smoker-pipeline/296/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fastify is failing on
AIX,WindowsandmacOSwhile passing ons390x. Removings390xfrom the skip list and addingwin32anddarwinwhile keepingaixskipped.CITGM smoke test passed on s390x with Node.js v22.23.2
Checklist
npm testpasseshere