Skip to content

perf: skip class checks for unrelated identifiers #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BridgeAR wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf: skip class checks for unrelated identifiers #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lexer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,8 @@ function parseSource (cjsSource) {
}
break;
case 99/*c*/:
if (keywordStart(pos) && source.startsWith('lass', pos + 1) && isBrOrWs(source.charCodeAt(pos + 5)))
if (source.charCodeAt(pos + 1) === 108/*l*/ && keywordStart(pos) &&
source.startsWith('ass', pos + 2) && isBrOrWs(source.charCodeAt(pos + 5)))
nextBraceIsClass = true;
break;
case 109/*m*/:
Expand Down
17 changes: 17 additions & 0 deletions test/_unit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,6 +478,23 @@ suite('Lexer', () => {
`);
});

test('Class keyword detection', () => {
for (const whitespace of ['\t', '\n', '\v', '\f', '\r', ' ', '\u00a0']) {
const result = parse(`class${whitespace}Example {}/regex/.test('regex'); exports.value = 1`);
assert.deepStrictEqual(result.exports, ['value']);
assert.deepStrictEqual(result.reexports, []);
}
for (const source of [
'const className = {} / 2; exports.value = className',
'const close = {} / 2; exports.value = close',
'const value = {}; value.class = {} / 2; exports.value = value'
]) {
const result = parse(source);
assert.deepStrictEqual(result.exports, ['value']);
assert.deepStrictEqual(result.reexports, []);
}
});

test('Regexp division', () => {
parse(`\nconst x = num / /'/.exec(l)[0].slice(1, -1)//'"`);
});
Expand Down
Loading