Skip to content

test: replace the deprecated option - #1097

Merged
avivkeller merged 1 commit into
nodejs:mainfrom
btea:test/repace-deprecated-option
Sep 15, 2026
Merged

avivkeller merged 1 commit into
nodejs:mainfrom
btea:test/repace-deprecated-option

Conversation

@btea

@btea btea commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Description

https://beta.docs.nodejs.org/test#mockmodulespecifier-options:~:text=This%20option%20is%20deprecated%20and%20will%20be%20removed%20in%20a%20later%20version.%20Prefer%20options.exports.default.

https://beta.docs.nodejs.org/test#mockmodulespecifier-options:~:text=options.exports.-,This%20option%20is%20deprecated%20and%20will%20be%20removed%20in%20a%20later%20version.%20Prefer%20options.exports.,-Returns%3A

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run node --run test and all tests passed.
  • I have check code formatting with node --run format:check & node --run lint.
  • I've covered new added functionality with unit tests if necessary.

@btea
btea requested a review from a team as a code owner September 13, 2026 09:30
@vercel

vercel Bot commented Sep 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
api-docs-tooling Ready Ready Preview Sep 13, 2026 9:32am UTC

Request Review

@codecov

codecov Bot commented Sep 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.70%. Comparing base (e3c6ab8) to head (e024bfa).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
packages/core/src/__tests__/generators.test.mjs 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1097      +/-   ##
==========================================
+ Coverage   90.60%   90.70%   +0.09%     
==========================================
  Files         217      220       +3     
  Lines       20813    21137     +324     
  Branches     1974     1991      +17     
==========================================
+ Hits        18858    19172     +314     
- Misses       1948     1958      +10     
  Partials        7        7              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

api-links Generator

Performance estimate (single CI run)

  • Generation time: 31.9% faster (1.35 s → 920.00 ms)
  • Peak memory: 18.9% higher (355.11 MB → 422.19 MB)

legacy-html Generator

Performance estimate (single CI run)

  • Generation time: 9.7% faster (41.02 s → 37.06 s)
  • Peak memory: 5.0% higher (2.32 GB → 2.44 GB)

legacy-json Generator

Performance estimate (single CI run)

  • Generation time: 5.6% slower (7.92 s → 8.36 s)
  • Peak memory: 10.7% lower (1.67 GB → 1.49 GB)

llms-txt Generator

Performance estimate (single CI run)

  • Generation time: 17.9% faster (5.48 s → 4.50 s)
  • Peak memory: 22.2% higher (1.48 GB → 1.81 GB)

orama-db Generator

Output size: 1 file changed · net +1.00 B

File size details
File Main PR Change
orama-db.json 9.39 MB 9.39 MB +1.00 B (+0.0%)

Performance estimate (single CI run)

  • Generation time: 18.3% faster (7.39 s → 6.04 s)
  • Peak memory: 12.0% lower (1.79 GB → 1.58 GB)

web Generator

Performance estimate (single CI run)

  • Generation time: 0.1% faster (64.57 s → 64.52 s)
  • Peak memory: 0.6% lower (3.22 GB → 3.20 GB)

@avivkeller
avivkeller enabled auto-merge (squash) September 15, 2026 18:29
@avivkeller
avivkeller disabled auto-merge September 15, 2026 18:29
@avivkeller
avivkeller merged commit 91c9fc6 into nodejs:main Sep 15, 2026
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants