Repository navigation
Conversation
all.html, every module page's content on one page, is Node.js's, but html built it in, behind generateAllPage, and the streaming work spread its bookkeeping through generate.mjs. It's now a generator of @node-core/doc-kit, html-all, spliced between jsx-ast and html the way section-pages is between metadata and jsx-ast. It passes the pages on, adds all.html's metadata to the manifest, and right after the last module page adds all.html as a page made of theirs, in sidebar order. html only knows that an item with parts, the pages before it that it's made of, is compiled from their content and rendered first, one part at a time instead of building every part's elements before rendering any; generateAllPage goes away. Built with the Node.js preset and the html-all target, the Node.js API docs come out byte-identical, all.html included, at 1 and 4 threads. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com> Assisted-by: Claude Sonnet 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## perf/stream-html #1242 +/- ##
====================================================
+ Coverage 94.61% 94.64% +0.03%
====================================================
Files 295 297 +2
Lines 31659 31876 +217
Branches 3227 3243 +16
====================================================
+ Hits 29953 30168 +215
- Misses 1684 1686 +2
Partials 22 22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
|
ovflowd
marked this pull request as ready for review
November 3, 2026 20:39
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR moves
all.html, every module page's content on one page, out ofhtmland into a new generator of@node-core/doc-kit,html-all. It's the sixth part of a stack that splits #1205.It's Node.js's, so
doc-kititself shouldn't need to know about it, buthtmlbuilt it in behindgenerateAllPage, and the streaming work spread its bookkeeping throughgenerate.mjs.html-allis spliced betweenjsx-astandhtml, the waysection-pagesis betweenmetadataandjsx-ast. It passes the pages on, addsall.html's head to the manifest, and right after the last module page addsall.htmlas a page made of theirs, in sidebar order.htmlonly knows that an item withparts, the pages before it that it's made of, is compiled from their content and rendered first, one part at a time instead of building every part's elements before rendering any. On Node.js's docs the worker renderingall.htmlwent from 330-388MB to 176-189MB live.generateAllPageis removed, which is a breaking change for@doc-kit/generator-react. Builds that wantall.htmladd thehtml-alltarget, as CI's e2e build now does (-t web -t html-all). Node.js's config (doc: move to redesign node#66713) needs it intargettoo.Validation
Added tests for
html-all(all.htmlright after its last part in sidebar order, and after every page given at once as with one thread), and forhtmlassembling a page from its parts' content, numbering their ids across parts, and importing no component into it whatever the components are named. With thehtml-alltarget added, the output on 12 of Node.js's API docs is byte-identical tomain's,all.htmlincluded, at 1 and 4 threads.Related Issues
Refs: #1205
Check List
node --run testand all tests passed.node --run format:check&node --run lint.