Repository navigation
Conversation
With generators streaming into each other, more threads now pay off, so DEFAULT_MAX_THREADS goes from 4 to 6. On the Node.js API docs the site build is ~15% faster at 6 threads than at 4, for ~20% more memory; 8 threads were no faster than 6 and used ~15% more. Machines with fewer CPUs, like CI's 4, are unaffected, and --threads still sets any count. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com> Assisted-by: Claude Sonnet 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
4 tasks done
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor/html-all #1243 +/- ##
==================================================
Coverage 94.64% 94.64%
==================================================
Files 297 297
Lines 31876 31877 +1
Branches 3243 3243
==================================================
+ Hits 30168 30169 +1
Misses 1686 1686
Partials 22 22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
|
avivkeller
approved these changes
Nov 3, 2026
ovflowd
marked this pull request as ready for review
November 3, 2026 20:39
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes builds use up to 6 threads by default, instead of 4. It's the last part of the stack that splits #1205. With generators streaming into each other, more threads now pay off:
mainonly goes from 9.55s at 4 threads to 8.82s at 6, while with the stack the site build goes from 7.64s to 6.48s.8 threads were no faster than 6 for the site build, and used ~15% more memory. Machines with fewer CPUs, like CI's 4, are unaffected, and
--threadsstill sets any count.Validation
Node.js's docs on Node.js 24, medians of 5 interleaved runs. The site is
orama-db,json,llms-txtandsection-pages(which pulls injsx-astandhtml), legacy islegacy-html-allandlegacy-json-all. This column is the whole stack:mainAt the new default, against other thread counts:
-p 1with--max-old-space-size=512still passes, at ~1.0GB peak RSS.Related Issues
Refs: #1205, and nodejs/nodejs.org#9253, which caches tokens for both themes and makes the site build faster still.
Check List
node --run testand all tests passed.node --run format:check&node --run lint.