add AsyncResource::makeCallbackScope

[mmomtchev]

Refs: #1024

Add nan::AsyncResource::makeCallbackScope wrapper aroiund node::CallbackScope.

The problem with calling node::CallbackScope directly is that the node::async_context is a private member of nan::AsyncResource.

This allows to run properly the microtasks queue for async workers that do not call JavaScript.

This require Node.js 9.0.0, as before this version the microtasks queue was always run automatically.

In reality, Node.js 26.4.0 is the first version that actually does not do this, although this has been specified since Node.js 9.0.0.

[mmomtchev]

Returning a non-copyable object from a factory using an initializer-list is C++11.

[Flarna]

doesn't this require an ifdef for all users supporting ancient node.js versions if there is no dummy implementation for these older node.js versions?

[kkoopa]

You are right, there should be noop implementations for the ancient versions.

…

On Fri, Sep 25, 2026, 21:51 Gerhard Stöbich ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In nan.h <#1026 (comment)>: > @@ -660,6 +660,12 @@ class AsyncResource { #endif } +#if NODE_MODULE_VERSION >= NODE_9_0_MODULE_VERSION + inline node::CallbackScope makeCallbackScope(v8::Local<v8::Object> target) { + return {v8::Isolate::GetCurrent(), target, context}; + } +#endif doesn't this require an ifdef for all consumer supporting ancient node.js versions if there is no dummy implementation for these older node.js versions? — Reply to this email directly, view it on GitHub <#1026?email_source=notifications&email_token=AA7JXKOESZXZBKH6S3RD7R35Q25BVA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMZSGE2TAOJTHE42M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSWGM33PORSXEX3DNRUWG2Y#pullrequestreview-5321509399>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA7JXKOOLXTRTD2I5HHJQRL5Q25BVAVCNFSNUABEKJSXA33TNF2G64TZHMYTCNJUGU4TEOB3JFZXG5LFHM2TKNJTGU3TIOJZGCQXMAQ> . Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS <https://github.com/notifications/mobile/ios/AA7JXKJWICMHP2BFZYKSST35Q25BVA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMZSGE2TAOJTHE42M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSVGM33PORSXEX3JN5ZQ> and Android <https://github.com/notifications/mobile/android/AA7JXKPFBHQI667LXA3IC4T5Q25BVA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMZSGE2TAOJTHE42M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSXGM33PORSXEX3BNZSHE33JMQ>. Download it today! You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>