Skip to content

docs: remove "npm test-all" from CONTRIBUTING.md"#1109

Merged
Renegade334 merged 1 commit into
nodejs:mainfrom
sxa:no-npm-test
Jul 1, 2026
Merged

docs: remove "npm test-all" from CONTRIBUTING.md"#1109
Renegade334 merged 1 commit into
nodejs:mainfrom
sxa:no-npm-test

Conversation

@sxa

@sxa sxa commented Jul 1, 2026

Copy link
Copy Markdown
Member

Spotted during #1108
npm test-all seems to have been removed from package.json in https://github.com/nodejs/node-core-utils/pull/670/changes#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519 but was left in the documentation. If something else should replace it then let me know, otherwise removing it and leaving npm test in there seems reasonable.

Signed-off-by: Stewart X Addison <sxa@ibm.com>
@sxa

sxa commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

FYI @aduh95 as the author of the original PR. I don't seem to have permissions to assign you as an explicit reviewer.

@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.52%. Comparing base (2d1085f) to head (049dfda).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1109   +/-   ##
=======================================
  Coverage   64.52%   64.52%           
=======================================
  Files          45       45           
  Lines        7003     7003           
=======================================
  Hits         4519     4519           
  Misses       2484     2484           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Renegade334 Renegade334 merged commit b970144 into nodejs:main Jul 1, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants