Skip to content

sea: add test and update docs for import() with code cache - #62678

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
thisalihassan:sea/import-with-code-cache
Sep 27, 2026
Merged

nodejs-github-bot merged 2 commits into
nodejs:mainfrom
thisalihassan:sea/import-with-code-cache

Conversation

@thisalihassan

Copy link
Copy Markdown
Contributor
  • Remove the **Note:** import() does not work when useCodeCache is true. restriction from the API documentation.

Assisted by: Claude Opus 4.6

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/single-executable

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. single-executable Issues and PRs related to single-executable applications. labels Apr 10, 2026
@codecov

codecov Bot commented Apr 10, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.48%. Comparing base (de5644c) to head (731eff1).
⚠️ Report is 2281 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62678      +/-   ##
==========================================
+ Coverage   89.81%   92.48%   +2.66%     
==========================================
  Files         699      809     +110     
  Lines      216235   299477   +83242     
  Branches    41336    80051   +38715     
==========================================
+ Hits       194216   276977   +82761     
+ Misses      14129    12978    -1151     
- Partials     7890     9522    +1632     
Files with missing lines Coverage Δ
src/node_sea.cc 92.89% <ø> (+3.36%) ⬆️

... and 537 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Ali Hassan <ali-hassan27@outlook.com>
@thisalihassan
thisalihassan force-pushed the sea/import-with-code-cache branch from c3bb922 to ead9914 Compare April 10, 2026 20:26
Comment thread test/sea/test-single-executable-application-use-code-cache-dynamic-import.js Outdated
…amic-import.js

Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Apr 29, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Apr 29, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

@github-actions github-actions Bot added the stale Issues and PRs marked stale due to inactivity and scheduled for automatic closure. label Jul 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically closed after 30 days of inactivity following its stale status (no activity for a total of 120 days).
If this is still relevant, feel free to reopen it or leave a comment with additional details so we can continue the discussion.

@github-actions github-actions Bot closed this Aug 28, 2026
@inoway46 inoway46 reopened this Sep 27, 2026
@inoway46

Copy link
Copy Markdown
Contributor

Reopening since this still seems relevant on current main.

@inoway46 inoway46 added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed stale Issues and PRs marked stale due to inactivity and scheduled for automatic closure. labels Sep 27, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 27, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@inoway46 inoway46 added commit-queue-squash PRs the Commit Queue should land as one squashed commit. commit-queue PRs queued for automated landing through the Commit Queue. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Sep 27, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 7d79ed3 into nodejs:main Sep 27, 2026
112 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 7d79ed3

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 27, 2026
aduh95 pushed a commit that referenced this pull request Sep 27, 2026
Signed-off-by: Ali Hassan <ali-hassan27@outlook.com>
PR-URL: #62678
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
HoonDongKang pushed a commit to HoonDongKang/node that referenced this pull request Sep 28, 2026
Signed-off-by: Ali Hassan <ali-hassan27@outlook.com>
PR-URL: nodejs#62678
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
aduh95 pushed a commit that referenced this pull request Sep 28, 2026
Signed-off-by: Ali Hassan <ali-hassan27@outlook.com>
PR-URL: #62678
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run. single-executable Issues and PRs related to single-executable applications.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants