stream: fix ERR_INVALID_STATE when cancelling Readable.toWeb() by richardscarrott · Pull Request #62773 · nodejs/node

richardscarrott · 2026-04-16T10:18:36Z

When a web ReadableStream returned by Readable.toWeb() is cancelled while the underlying Readable is actively producing data, a pending onData callback can still fire after the controller has been closed and attempt to enqueue a chunk, throwing ERR_INVALID_STATE.

Check wasCanceled in the onData handler and return early to avoid calling controller.enqueue() on a closed controller.

Refs: #54205

codecov · 2026-04-16T20:18:15Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.17%. Comparing base (fd5b135) to head (c0fe52d).
⚠️ Report is 484 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #62773      +/-   ##
==========================================
+ Coverage   90.12%   90.17%   +0.05%     
==========================================
  Files         752      771      +19     
  Lines      252325   264910   +12585     
  Branches    47456    50310    +2854     
==========================================
+ Hits       227407   238894   +11487     
- Misses      16217    16981     +764     
- Partials     8701     9035     +334

Files with missing lines	Coverage Δ
lib/internal/webstreams/adapters.js	`88.04% <100.00%> (+1.43%)`	⬆️

... and 260 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

efekrskl · 2026-07-17T14:15:25Z

Thank you for your contribution @richardscarrott!

Could you please fix the linting errors?

smoores-dev · 2026-08-19T14:58:18Z

Howdy folks! I think we're running into this as well — @richardscarrott if you don't have time to take this over the finish line, happy to take it over and fix the linting errors!

richardscarrott · 2026-08-19T15:12:59Z

@smoores-dev @efekrskl soz, forgot about this. I have some time tomorrow to fix this up.

richardscarrott · 2026-08-23T10:24:04Z

Rebased onto main and fixed the lint error.

Worth flagging for re-review: #62394 rewrote newReadableStreamFromStreamReadable after this PR was opened, so the patch needed porting — the onData logic now lives in an inline 'data' listener. I confirmed the race is still present on current main; without the guard, test-stream-readable-to-web-termination.js fails with:

TypeError [ERR_INVALID_STATE]: Invalid state: Controller is already closed
    at ReadableStreamDefaultController.enqueue (node:internal/webstreams/readablestream:1189:13)
    at Readable.onData (node:internal/webstreams/adapters:547:18)
    at flow (node:internal/streams/readable:1319:53)
    at resume_ (node:internal/streams/readable:1295:3)

Note this is the enqueue path, distinct from the close path in #54205 (which #54206 already fixed) — hence Refs: rather than Fixes:. Upstream's rewritten test file is preserved as-is with the new case appended.

@meixg your approval predates the rebase, so this likely needs another look.

When a web ReadableStream returned by Readable.toWeb() is cancelled while the underlying Readable is actively producing data, a pending onData callback can still fire after the controller has been closed and attempt to enqueue a chunk, throwing ERR_INVALID_STATE. Check wasCanceled in the onData handler and return early to avoid calling controller.enqueue() on a closed controller. Refs: nodejs#54205 Signed-off-by: Richard Scarrott <riscarrott@googlemail.com>

richardscarrott · 2026-09-07T12:35:38Z

Added the missing Signed-off-by trailer (thanks @MikeMcC399) — message-only amend, so the tree is identical to the previously reviewed commit. lint-commit-message is green now.

Could a collaborator start a fresh CI run and re-add the author ready label? The force-push cleared it (@meixg's approval still stands).

MikeMcC399 · 2026-09-07T13:07:48Z

Added the missing Signed-off-by trailer (thanks @MikeMcC399) — message-only amend, so the tree is identical to the previously reviewed commit. lint-commit-message is green now.

Thanks for fixing the trailer!

Could a collaborator start a fresh CI run and re-add the author ready label? The force-push cleared it (@meixg's approval still stands).

@panva is re-running the GitHub Actions CI. I have put back the author ready PRs with CI started, the required approvals, and no outstanding review comments. label, although I don't believe that's a critical point.

It's going to need another Jenkins CI triggered, however there is currently some work being done to fix a flaky test, so I'll let @panva continue looking after your PR. ~~I'm not sure if @meixg will need to reapprove or not. We'll see!~~

panva

lgtm

nodejs-github-bot · 2026-09-12T08:11:09Z

CI: https://ci.nodejs.org/job/node-test-pull-request/77396/

nodejs-github-bot · 2026-09-12T10:43:50Z

Landed in 1278496

When a web ReadableStream returned by Readable.toWeb() is cancelled while the underlying Readable is actively producing data, a pending onData callback can still fire after the controller has been closed and attempt to enqueue a chunk, throwing ERR_INVALID_STATE. Check wasCanceled in the onData handler and return early to avoid calling controller.enqueue() on a closed controller. Refs: #54205 Signed-off-by: Richard Scarrott <riscarrott@googlemail.com> PR-URL: #62773 Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

…100) The Node 26 CI job is green again. Node 26.10 fixed the uncatchable `ERR_INVALID_STATE` crash when a `Readable.toWeb` stream is cancelled mid-upload (nodejs/node#62773). The two tests that expected the plain adapter to crash started failing, so they are removed. `toWebReadableStream` keeps working as before, and its doc comment now says to switch back to `Readable.toWeb` once every supported Node release has the fix. ## Fixes - `test_node_matrix (26)` no longer fails with `expected 0 to be greater than 0` on Node 26.10. - The tests showing `toWebReadableStream` survives aborted HTTP/1 and HTTP/2 uploads are unchanged and still run on every Node version. ## Context - The removed tests came from #76. They were meant to fail once Node shipped a fix, and Node 26.10 is that fix. - The workaround stays: Node 22.23 and 24.21 still crash when checked locally, and CI also tests Node 20. ## Testing - `packages/node/src/utils.test.ts` passes on Node 22.23, 24.21, 26.7 and 26.10. - Lint and type check pass.

When a web ReadableStream returned by Readable.toWeb() is cancelled while the underlying Readable is actively producing data, a pending onData callback can still fire after the controller has been closed and attempt to enqueue a chunk, throwing ERR_INVALID_STATE. Check wasCanceled in the onData handler and return early to avoid calling controller.enqueue() on a closed controller. Refs: #54205 Signed-off-by: Richard Scarrott <riscarrott@googlemail.com> PR-URL: #62773 Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot added needs-ci PRs that need a full CI run. web streams Issues and PRs related to the Web Streams API. labels Apr 16, 2026

meixg approved these changes Apr 17, 2026

View reviewed changes

dushyant-hada-90 mentioned this pull request Jul 16, 2026

Readable.toWeb(): uncaughtException (ERR_INVALID_STATE "Controller is already closed") when the stream is canceled during backpressure resume #64529

Open

richardscarrott force-pushed the fix/readable-to-web-cancel-race branch from 96e546b to 93b1db6 Compare August 23, 2026 10:13

aqm857886159 mentioned this pull request Aug 24, 2026

ReadableStreamFrom: unguarded delayed controller.close() throws uncatchable ERR_INVALID_STATE when an async-iterable body is cancelled nodejs/undici#5715

Closed

meixg approved these changes Sep 6, 2026

View reviewed changes

meixg added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Sep 6, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 6, 2026

This comment has been minimized.

Sign in to view

meixg added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 6, 2026

nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 6, 2026

This comment was marked as resolved.

Sign in to view

panva removed author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Sep 7, 2026

richardscarrott force-pushed the fix/readable-to-web-cancel-race branch from 93b1db6 to c0fe52d Compare September 7, 2026 12:29

MikeMcC399 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 7, 2026

panva approved these changes Sep 7, 2026

View reviewed changes

panva added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 7, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 7, 2026

This comment has been minimized.

Sign in to view

jasnell approved these changes Sep 8, 2026

View reviewed changes

panva added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 12, 2026

nodejs-github-bot merged commit 1278496 into nodejs:main Sep 12, 2026
76 checks passed

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 12, 2026

github-actions Bot mentioned this pull request Sep 20, 2026

2026-09-22, Version 26.10.0 (Current) #66163

Merged

dinwwwh mentioned this pull request Sep 25, 2026

test(node): drop Readable.toWeb crash tests now fixed in Node 26.10 middleapi/standard-server#100

Merged

Navigation Menu

Uh oh!

stream: fix ERR_INVALID_STATE when cancelling Readable.toWeb() - #62773

stream: fix ERR_INVALID_STATE when cancelling Readable.toWeb()#62773
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
richardscarrott:fix/readable-to-web-cancel-race

richardscarrott commented Apr 16, 2026

Uh oh!

codecov Bot commented Apr 16, 2026 •

edited

Loading

Uh oh!

efekrskl commented Jul 17, 2026 •

edited

Loading

Uh oh!

smoores-dev commented Aug 19, 2026

Uh oh!

richardscarrott commented Aug 19, 2026

Uh oh!

richardscarrott commented Aug 23, 2026

Uh oh!

This comment has been minimized.

This comment was marked as resolved.

This comment was marked as resolved.

Uh oh!

richardscarrott commented Sep 7, 2026

Uh oh!

MikeMcC399 commented Sep 7, 2026 •

edited

Loading

Uh oh!

panva left a comment

Uh oh!

This comment has been minimized.

nodejs-github-bot commented Sep 12, 2026

Uh oh!

Uh oh!

nodejs-github-bot commented Sep 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

richardscarrott commented Apr 16, 2026

Uh oh!

codecov Bot commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

efekrskl commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smoores-dev commented Aug 19, 2026

Uh oh!

richardscarrott commented Aug 19, 2026

Uh oh!

richardscarrott commented Aug 23, 2026

Uh oh!

This comment has been minimized.

This comment was marked as resolved.

This comment was marked as resolved.

Uh oh!

richardscarrott commented Sep 7, 2026

Uh oh!

MikeMcC399 commented Sep 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

panva left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

nodejs-github-bot commented Sep 12, 2026

Uh oh!

Uh oh!

nodejs-github-bot commented Sep 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

codecov Bot commented Apr 16, 2026 •

edited

Loading

efekrskl commented Jul 17, 2026 •

edited

Loading

MikeMcC399 commented Sep 7, 2026 •

edited

Loading