http: create header field names as internalized strings#64277
Open
araujogui wants to merge 1 commit into
Open
Conversation
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
There was a problem hiding this comment.
Pull request overview
This PR optimizes HTTP header processing by internalizing header field name strings so repeated header names can compare faster (e.g., in JS matchKnownFields()) and reduce duplicate string allocations when building req.headers.
Changes:
- Add
StringPtr::ToInternalizedString()to create V8 internalized strings from header field names. - Use internalized strings for header field names when constructing the headers array passed to JS.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+237
to
+246
| Local<String> ToInternalizedString(Environment* env) const { | ||
| if (size_ != 0) { | ||
| return String::NewFromOneByte(env->isolate(), | ||
| reinterpret_cast<const uint8_t*>(str_), | ||
| NewStringType::kInternalized, | ||
| size_) | ||
| .ToLocalChecked(); | ||
| } | ||
| return String::Empty(env->isolate()); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internalize header field names so repeated occurrences resolve to the same string in the isolate's string table, speeding up
matchKnownFields()comparisons andreq.headersbuilds.