v8: expose size and count in heap profile output - #65737
Merged
Merged
Conversation
nodejs-github-bot
added
c++
Signed-off-by: ishabi <ilyasshabi94@gmail.com>
IlyasShabi
force-pushed
the
ishabi/heap-size-count
branch
from
September 2, 2026 09:48
30b4ca6 to
55080ea
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65737 +/- ##
==========================================
- Coverage 90.05% 89.98% -0.07%
==========================================
Files 754 755 +1
Lines 256518 257288 +770
Branches 48534 48772 +238
==========================================
+ Hits 231007 231527 +520
- Misses 16609 16863 +254
+ Partials 8902 8898 -4
🚀 New features to boost your workflow:
|
addaleax
approved these changes
Sep 25, 2026
addaleax
added
semver-minor
addaleax
changed the title
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
Collaborator
panva
added
the
commit-queue
Collaborator
|
Landed in cf072ab |
nodejs-github-bot
removed
the
commit-queue
aduh95
pushed a commit
that referenced
this pull request
Sep 27, 2026
Signed-off-by: ishabi <ilyasshabi94@gmail.com> PR-URL: #65737 Reviewed-By: Anna Henningsen <anna@addaleax.net>
HoonDongKang
pushed a commit
to HoonDongKang/node
that referenced
this pull request
Sep 28, 2026
Signed-off-by: ishabi <ilyasshabi94@gmail.com> PR-URL: nodejs#65737 Reviewed-By: Anna Henningsen <anna@addaleax.net>
aduh95
pushed a commit
that referenced
this pull request
Sep 28, 2026
Signed-off-by: ishabi <ilyasshabi94@gmail.com> PR-URL: #65737 Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v8.startHeapProfile().stop()returns the sampling heap profile in the CDT format. That format reports onlysize(= objectSize × objectCount) per sample andselfSizeper node, discarding the object count and the live/collected distinction that V8 already tracks.In this PR every existing CDT field keeps its name and value, and :
selfCount(number of sampled objects) alongsideselfSize(total bytes).objectSize,objectCount, andisLive.