test: ensure fsPromises.watch rejects on abort - #65768
Merged
Merged
Conversation
Signed-off-by: hanityx <hanityx@gmail.com>
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65768 +/- ##
==========================================
+ Coverage 89.97% 90.07% +0.09%
==========================================
Files 757 769 +12
Lines 257376 261316 +3940
Branches 48791 49633 +842
==========================================
+ Hits 231574 235372 +3798
- Misses 16886 16997 +111
- Partials 8916 8947 +31 🚀 New features to boost your workflow:
|
Contributor
Author
|
Friendly ping @lpinca, PTAL when you get a chance! |
lpinca
approved these changes
Sep 19, 2026
lpinca
added
the
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
panva
added
author ready
github-actions
Bot
removed
the
resume-ci
Collaborator
panva
added
the
commit-queue
Collaborator
|
Landed in 30c5a65 |
nodejs-github-bot
removed
the
commit-queue
HoonDongKang
pushed a commit
to HoonDongKang/node
that referenced
this pull request
Sep 28, 2026
Signed-off-by: hanityx <hanityx@gmail.com> PR-URL: nodejs#65768 Refs: nodejs#58490 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The abort case in test-fs-promises-watch.js only asserts inside a catch block, so if the iterator finishes without throwing the test still passes. Every other rejection in this file uses assert.rejects(), so I switched this one over as well.
Since #58490 the post-loop throw in lib/internal/fs/watchers.js is the only place a mid-iteration abort turns into an AbortError. I removed that throw locally to check, and the old test still passed while the updated test failed with
Missing expected rejection.Refs: #58490