[v24.x] test: skip RSA-PSS keygen deprecation tests with BoringSSL - #65808
Open
codebytere wants to merge 1 commit into
Open
codebytere wants to merge 1 commit into
codebytere wants to merge 1 commit into
Conversation
panva
approved these changes
Sep 5, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v24.x-staging #65808 +/- ##
=================================================
- Coverage 90.31% 90.30% -0.01%
=================================================
Files 711 718 +7
Lines 228425 238008 +9583
Branches 43160 45242 +2082
=================================================
+ Hits 206293 214925 +8632
- Misses 14090 14601 +511
- Partials 8042 8482 +440 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
aduh95
force-pushed
the
v24.x-staging
branch
3 times, most recently
from
September 9, 2026 21:47
7fc125b to
e711d3f
Compare
codebytere
force-pushed
the
v24.x-test-boringssl-crypto
branch
from
September 10, 2026 08:54
efc02c2 to
88e9834
Compare
panva
approved these changes
Sep 19, 2026
This comment has been minimized.
This comment has been minimized.
aduh95
force-pushed
the
v24.x-staging
branch
from
September 19, 2026 14:06
00d2960 to
4396c9b
Compare
panva
approved these changes
Sep 19, 2026
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
panva
approved these changes
Sep 21, 2026
Collaborator
Member
|
@aduh95 this is good to go. |
Contributor
|
This pull request has conflicts with its base branch, removing the |
test-crypto-keygen-deprecation and test-crypto-keygen-duplicate-deprecated-option generate rsa-pss key pairs, which BoringSSL does not support. The other rsa-pss keygen tests skip there since nodejs#62883, but these two only exist on v24.x (nodejs#58706 removed them from main earlier), so its backport could not cover them. Refs: nodejs#62883 Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
codebytere
force-pushed
the
v24.x-test-boringssl-crypto
branch
from
September 30, 2026 09:39
88e9834 to
ef9e73a
Compare
panva
approved these changes
Sep 30, 2026
richardlau
approved these changes
Sep 30, 2026
Collaborator
Collaborator
Member
|
@aduh95 this is ready (again) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-crypto-keygen-deprecationandtest-crypto-keygen-duplicate-deprecated-optionfail on v24.x-staging when Node is built with--shared-opensslagainst BoringSSL, because they generatersa-psskey pairs and BoringSSL doesn't support that.The other rsa-pss keygen tests skip there since #62883, but these two were already gone from main (#58706), so that backport never touched them. They now skip too.
This PR also used to adjust
test-crypto-pqc-key-objects-ml-dsaand-ml-kem; #66233 made them expect the seed-only export on every backend, so that commit is dropped.Tests: before the rebase, built v24.x-staging against the
boringsslthattools/nix/openssl-matrix.nixpins on main (0.20260803.0) on linux-x64 and ranparallelandsequential; both tests pass with this change. Not rebuilt against BoringSSL since the rebase. The OpenSSL paths are unchanged.cc @nodejs/crypto
Disclosure: the code and this description were written by Claude Code, directed and reviewed by @codebytere.