Skip to content

[v24.x] test: skip RSA-PSS keygen deprecation tests with BoringSSL - #65808

Open
codebytere wants to merge 1 commit into
nodejs:v24.x-stagingfrom
codebytere:v24.x-test-boringssl-crypto
Open

codebytere wants to merge 1 commit into
nodejs:v24.x-stagingfrom
codebytere:v24.x-test-boringssl-crypto

Conversation

@codebytere

@codebytere codebytere commented Sep 5, 2026 •

Copy link
Copy Markdown
Member

test-crypto-keygen-deprecation and test-crypto-keygen-duplicate-deprecated-option fail on v24.x-staging when Node is built with --shared-openssl against BoringSSL, because they generate rsa-pss key pairs and BoringSSL doesn't support that.

The other rsa-pss keygen tests skip there since #62883, but these two were already gone from main (#58706), so that backport never touched them. They now skip too.

This PR also used to adjust test-crypto-pqc-key-objects-ml-dsa and -ml-kem; #66233 made them expect the seed-only export on every backend, so that commit is dropped.

Tests: before the rebase, built v24.x-staging against the boringssl that tools/nix/openssl-matrix.nix pins on main (0.20260803.0) on linux-x64 and ran parallel and sequential; both tests pass with this change. Not rebuilt against BoringSSL since the rebase. The OpenSSL paths are unchanged.

cc @nodejs/crypto


Disclosure: the code and this description were written by Claude Code, directed and reviewed by @codebytere.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch. labels Sep 5, 2026
@codecov

codecov Bot commented Sep 5, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.30%. Comparing base (9e39360) to head (ef9e73a).
⚠️ Report is 584 commits behind head on v24.x-staging.

Additional details and impacted files
@@                Coverage Diff                @@
##           v24.x-staging   #65808      +/-   ##
=================================================
- Coverage          90.31%   90.30%   -0.01%     
=================================================
  Files                711      718       +7     
  Lines             228425   238008    +9583     
  Branches           43160    45242    +2082     
=================================================
+ Hits              206293   214925    +8632     
- Misses             14090    14601     +511     
- Partials            8042     8482     +440     

see 258 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@aduh95
aduh95 force-pushed the v24.x-staging branch 3 times, most recently from 7fc125b to e711d3f Compare September 9, 2026 21:47
@codebytere
codebytere force-pushed the v24.x-test-boringssl-crypto branch from efc02c2 to 88e9834 Compare September 10, 2026 08:54
@panva panva added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Sep 19, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 19, 2026
@nodejs-github-bot

This comment has been minimized.

@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 19, 2026
@github-actions github-actions Bot added request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. and removed request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Sep 19, 2026
@github-actions

This comment was marked as outdated.

@panva panva removed the request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. label Sep 19, 2026
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@panva
panva requested a review from aduh95 September 22, 2026 17:57
@panva

panva commented Sep 22, 2026

Copy link
Copy Markdown
Member

@aduh95 this is good to go.

@codebytere codebytere added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 23, 2026
@github-actions github-actions Bot removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has conflicts with its base branch, removing the author ready label.
Please rebase your branch onto the latest base branch, resolve the conflicts locally, and force-push.
Afterwards the pull request needs a fresh collaborator approval, and a collaborator will add the label back once it is author ready again.

test-crypto-keygen-deprecation and
test-crypto-keygen-duplicate-deprecated-option generate rsa-pss key
pairs, which BoringSSL does not support. The other rsa-pss keygen tests
skip there since nodejs#62883, but these
two only exist on v24.x (nodejs#58706
removed them from main earlier), so its backport could not cover them.

Refs: nodejs#62883
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
@codebytere
codebytere force-pushed the v24.x-test-boringssl-crypto branch from 88e9834 to ef9e73a Compare September 30, 2026 09:39
@codebytere codebytere changed the title [v24.x] test: fix crypto tests against BoringSSL [v24.x] test: skip RSA-PSS keygen deprecation tests with BoringSSL Sep 30, 2026
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 30, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 30, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@panva panva added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 30, 2026
@panva

panva commented Sep 30, 2026

Copy link
Copy Markdown
Member

@aduh95 this is ready (again)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants