zlib: restart format detection when resetting Unzip - #66169
Open
marcopiraccini wants to merge 1 commit into
Open
marcopiraccini wants to merge 1 commit into
marcopiraccini wants to merge 1 commit into
Conversation
marcopiraccini
marked this pull request as ready for review
September 21, 2026 11:58
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66169 +/- ##
==========================================
- Coverage 90.36% 90.35% -0.02%
==========================================
Files 792 792
Lines 275398 275409 +11
Branches 52776 52774 -2
==========================================
- Hits 248877 248844 -33
- Misses 16937 16988 +51
+ Partials 9584 9577 -7
🚀 New features to boost your workflow:
|
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
marcopiraccini
force-pushed
the
zlib-unzip-reset
branch
from
September 28, 2026 03:53
389d0f6 to
c1557aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createUnzip().reset()left format detection state from the previous input. After a partial gzip header, the saved header-byte count was not cleared. After detecting gzip or zlib-wrapped deflate, the stream no longer used UNZIPmode to detect the next input's format.
PR #64620 proposed a similar fix and was closed without merging. This patch tracks whether the stream was created as UNZIP and separates public reset from the internal gzip-member reset. It also tests resetting from detected gzip to deflate.
Fixes: #64619