Skip to content

vfs: normalize RealFSProvider mkdir return paths - #66221

Open
trivikr wants to merge 2 commits into
nodejs:mainfrom
trivikr:vfs-normalize-realfsprovider-mkdir-return-paths
Open

trivikr wants to merge 2 commits into
nodejs:mainfrom
trivikr:vfs-normalize-realfsprovider-mkdir-return-paths

Conversation

@trivikr

@trivikr trivikr commented Sep 23, 2026

Copy link
Copy Markdown
Member

Fixes: #66220

RealFSProvider.mkdirSync()/mkdir() forwarded the raw fs.mkdirSync() result, which for { recursive: true } is the absolute backing-directory path of the first created directory. VirtualFileSystem#toMountedPath() then joined the mount point with it, producing <mount>/<root>/a instead of <mount>/a, so the returned path failed fs.existsSync().

Reuse the existing #resolvedToVfsPath() helper (as realpath does) to translate the result back to a provider-relative VFS path, matching MemoryProvider.


Assisted-by: opencode

RealFSProvider.mkdirSync()/mkdir() forwarded the raw fs.mkdirSync()
result, which for { recursive: true } is the absolute backing-directory
path of the first created directory. VirtualFileSystem#toMountedPath()
then joined the mount point with it, producing <mount>/<root>/a instead
of <mount>/a, so the returned path failed fs.existsSync().

Reuse the existing #resolvedToVfsPath() helper (as realpath does) to
translate the result back to a provider-relative VFS path, matching
MemoryProvider.

Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: opencode
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. vfs Issues and PRs related to the virtual filesystem subsystem. labels Sep 23, 2026
@trivikr trivikr added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 23, 2026
@codecov

codecov Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.36%. Comparing base (c0ed28f) to head (3b52939).
⚠️ Report is 139 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66221      +/-   ##
==========================================
+ Coverage   90.29%   90.36%   +0.07%     
==========================================
  Files         790      792       +2     
  Lines      272883   275396    +2513     
  Branches    52118    52781     +663     
==========================================
+ Hits       246387   248852    +2465     
- Misses      16943    16974      +31     
- Partials     9553     9570      +17     
Files with missing lines Coverage Δ
lib/internal/vfs/providers/real.js 95.75% <100.00%> (+0.06%) ⬆️

... and 141 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trivikr trivikr removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 24, 2026
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. vfs Issues and PRs related to the virtual filesystem subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vfs: recursive mkdir returns backing-directory path for RealFSProvider

2 participants