Skip to content

test: deflake watch mode tests #66232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Sep 23, 2026
Merged

test: deflake watch mode tests #66232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8777020
test: deflake watch mode tests
panva Sep 23, 2026
8f9a37b
fixup! test: deflake watch mode tests
panva Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions test/sequential/sequential.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@ prefix sequential
[true] # This section applies to all platforms
# https://github.com/nodejs/node/issues/27611#issuecomment-613100468
test-cpu-prof-dir-worker: PASS, FLAKY
# https://github.com/nodejs/node/issues/44898
test-watch-mode: PASS, FLAKY
test-watch-mode-inspect: PASS, FLAKY
# https://github.com/nodejs/node/issues/47409
test-http2-large-file: PASS, FLAKY

Expand Down
10 changes: 8 additions & 2 deletions test/sequential/test-watch-mode.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ function runInBackground({ args = [], options = {}, completed = 'Completed runni
future.resolve();
return { stdout, stderr };
},
restart(timeout = 1000) {
restart(timeout = common.platformTimeout(10_000)) {
if (!child) {
run();
}
Expand Down Expand Up @@ -996,6 +996,10 @@ process.on('message', (message) => {
});

it('should strip all watch flags from NODE_OPTIONS in child process', async () => {
// Avoid recursively watching the repository's source and test trees.
const cwd = tmpdir.resolve('node-options');
mkdirSync(path.join(cwd, 'src'), { recursive: true });
mkdirSync(path.join(cwd, 'test'));
const file = createTmpFile('console.log(process.env.NODE_OPTIONS);');
const nodeOptions = [
'--watch',
Expand All @@ -1012,6 +1016,7 @@ process.on('message', (message) => {
const { done, restart } = runInBackground({
args: ['--watch', file],
options: {
cwd,
env: { ...process.env, NODE_OPTIONS: nodeOptions },
},
});
Expand Down Expand Up @@ -1040,7 +1045,8 @@ process.on('message', (message) => {
writeFileSync(reqFile, 'globalThis.requiredOk = true;');

const file = createTmpFile('console.log("required:" + !!globalThis.requiredOk);');
const nodeOptions = `--watch --require "${reqFile}"`;
// Backslashes inside quoted NODE_OPTIONS values are escape characters.
const nodeOptions = `--watch --require "${reqFile.replaceAll(path.sep, '/')}"`;
const { done, restart } = runInBackground({
args: ['--watch', file],
options: {
Expand Down
Loading